Repository navigation
Conversation
Owner
Author
|
The mandatory fresh isolated Opus review was launched immediately after opening. It exited1 with “You've hit your weekly limit · resets 4pm (UTC)”; no review was obtained. This PR remains draft pending actual independent review and exact-head green CI. The targeted codec and ordinary-public-import consumer, all six exact standard-three axiom guards, DAG, Mathlib-free benchmark boundaries and admission checks pass. The full integrated build is still running. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary imports could not reveal the graph encoder's literal output, blocking proofs that numerical tower packets match their reconstructed source records. Add
Codec.graph_eq,entry_eqandnode_eqfor the existing encoders, and document exactly what their field equations establish. The existing ordinary-importHexSignDet.PublicCodecconsumer checks the requested graph-header equation, the entry fields and all eleven node fields, with six exact ordinary-kernel axiom guards.This addresses the concrete public-encoding request in #10378 (reproducer). It supplies equations for stored data; acceptance, context binding, root validation and the remaining frame/exporter work retain their existing contracts. Encoder/decoder implementations and the format are unchanged. No package, phase or computational performance claim changes.
Validation: core codec build (300 jobs), ordinary-public-import consumer (327 jobs), current DAG, all 67 Mathlib-free benchmark boundaries and 406 build-only proof probes, admission checks across 1,475 import cones / 2,387 local modules, and whitespace checks pass. Full integrated build passes (14,777 jobs). The six new guards check the permitted standard-three axiom closure. No new timings.
Refs #10575. Opened as a draft because the mandatory fresh Opus review must still be obtained; an isolated review attempt follows immediately after opening.