fix(replace): cut untracked spans in place across nested wrappers (#16)

[kklimuk]

🤖 docx-cli triage

What was wrong

docx replace inslink.docx "withhold a" "keep a" (untracked; the match starts in Reviewer A's <w:ins> and ends inside a <w:hyperlink> nested in it) printed replace 1 occurrence replaced and exited 0. The result read The Client may [a disputed](#x)keep aamount., and both halves of the split ins had w:id="1". The same offset miscount also hit any untracked match in a later run of a multi-run ins or hyperlink: replace "disputed" "contested" gave macontestedld a disputed amount..

What changed

• Untracked, a revision wrapper is no longer split. An additive <w:ins>/<w:moveTo> is cut in place by running the same walker over its content, so nested hyperlinks, fields and revisions are cut at the right offsets. The replacement lands where the match starts, so it stays in A's insertion, and no id is duplicated. A wrapper left with no children is dropped. A subtractive <w:del>/<w:moveFrom> stays whole.
• Tracked: when a wrapper is split, its post-half now gets a fresh w:id from the allocator.
• rebuildContainer now starts counting at the container's own offset (RunSlot.parentStart) and counts nested wrappers in any container.
• Files: src/core/find/replace-span.tsx, src/core/track-changes/CLAUDE.md (updated the known-gap notes), and tests/cli/replace.test.ts (8 tests; 7 of them fail on main).

Verification

• After: The Client may keep a[ disputed](#x) amount.. The XML is <w:ins w:id="1">may · keep a · <w:hyperlink> disputed</w:hyperlink> · amount.</w:ins>, with one id.
• The issue's input shape (<w:hyperlink> directly inside <w:ins>) already fails docx validate before any edit, because the schema only allows <w:ins> inside <w:hyperlink>. The tests for that shape skip the schema check. The other cases do validate.
• Also fixes Untracked replace inside another author's insertion that holds a nested deletion replaces the wrong span (0.27.0) #22 (untracked match after another author's <w:del> nested in the ins: main cut The Client may → Fees are due. disputed sumwithhold disputed amount.; now Fees are due. The Client may withhold disputed sum.). Its regression test was added in a follow-up commit and fails on main.
• bun run check ✅ bun run test:unit ✅ (1761 tests)
• /simplify (one pass, no Agent tool): reused placedReplacement in the hyperlink branch. /code-review xhigh: the forked review ran in the main checkout, not this branch, so it reviewed merged PRs Any write turns numeric character references (•, –) into literal text #12–fix(replace): tracked span inside another author's insertion splits it Word-style #20 instead of this diff. I reviewed this diff by hand and added 2 regression tests based on its offset findings.

Decisions for you

• Untracked: a replacement whose match starts inside another author's pending insertion now stays inside that insertion (credited to them), the same as a match wholly inside it. Before, it landed between two duplicate-id halves as plain text. OK?
• Still a known gap: a tracked (--track) match crossing a hyperlink nested inside another author's ins still cuts at the wrong offsets. Also, a tracked replace across a top-level hyperlink deletes the link's cut text without a <w:del> (read --baseline loses it). Should these be follow-up issues?

Action needed: approve/merge — review the two decisions above, then merge.

Fixes #16
Fixes #22

🤖 Generated with Claude Code

https://claude.ai/code/session_019XWuv9YGyEx2uZMPbg5Egd

---

Generated by Claude Code

---

Generated by Claude Code

[kklimuk]

🤖 docx-cli triage

This PR also fixes #22, reported by @Dmitry-Kov. In that issue, an untracked replace matches text that comes after another author's <w:del> nested in a pending <w:ins>.

Repro: run docx replace nested-deletion.docx "disputed amount" "disputed sum" on Fees are due. + <w:ins A>The Client may withhold <w:del B>any </w:del>disputed amount.</w:ins>.

• On main: the command printed replace 1 occurrence replaced and exited 0, but it cut the wrong span. The accepted text came out as Fees are due. disputed sumwithhold disputed amount.
• On this branch (before my new commit): the accepted text is Fees are due. The Client may withhold disputed sum. Reviewer B's <w:del> and Reviewer A's <w:ins w:id="1"> are otherwise unchanged, and docx validate passes.

What I changed: I pushed one test-only commit, 130838a (a match after a deletion nested in the ins cuts the right words (#22)). It fails against main's replace-span.tsx and passes here. I added Fixes #22 to the PR description. bun run check ✅ bun run test:unit ✅ (1761 tests). The commit only adds a test, so I reviewed it by hand instead of running /simplify and /code-review.

Action needed: approve/merge — review this PR's open decisions, then merge it to close both #16 and #22.

---

Generated by Claude Code