Skip to content

fix(bg/vat): accept 9-digit numbers whatever their first digit #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kallehauge wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(bg/vat): accept 9-digit numbers whatever their first digit #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ceb76f2
fix(bg/vat): accept 9-digit numbers whatever their first digit
kallehauge Oct 12, 2026
0c7e324
test(bg/vat): use Vivacom's VAT number as the example
kallehauge Oct 12, 2026
b51e1b0
test(bg/vat): describe the registered number by its rule, not its owner
kallehauge Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/bg/vat.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,18 @@ describe('bg/vat', () => {

expect(result.error).toBeInstanceOf(InvalidChecksum);
});

// A registered VAT number starting with 8. The first digit is not
// restricted: python-stdnum's bg/vat has no such rule.
it('validate:BG 831642181', () => {
const result = validate('BG 831642181');

expect(result.isValid && result.compact).toEqual('831642181');
});

it('validate:BG 831642182', () => {
const result = validate('BG 831642182');

expect(result.error).toBeInstanceOf(InvalidChecksum);
});
});
4 changes: 0 additions & 4 deletions src/bg/vat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,6 @@ const impl: Validator = {
return { isValid: false, error: new exceptions.InvalidFormat() };
}

if (!['0', '1', '2', '3', '9'].includes(value[0])) {
return { isValid: false, error: new exceptions.InvalidFormat() };
}

if (value.length === 9) {
if (!checkLegal(value)) {
return { isValid: false, error: new exceptions.InvalidChecksum() };
Expand Down