Skip to content

Apply and enforce clang-format - #484

Merged
dalg24 merged 4 commits into
kokkos:stablefrom
crtrott:apply-clang-format
Oct 15, 2026
Merged

dalg24 merged 4 commits into
kokkos:stablefrom
crtrott:apply-clang-format

Conversation

@crtrott

@crtrott crtrott commented Oct 15, 2026

Copy link
Copy Markdown
Member

The first two commits add/modify the pre-commit setup.
The third commit applies some clang-format off/on comments to prevent formatting of list like things, and some macro based code which gets really ugly.
The fourth commit is the actual apply-clang-format.

lucbv and others added 4 commits October 15, 2026 12:03
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Don't format some list like places in benchmarks and tests

Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>

@dalg24 dalg24 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which .clang-format file did you use (the .clang-format file was added)
Please cherry-pick the enforcement from #473 (added in .pre-commit-config.yaml)

@crtrott crtrott mentioned this pull request Oct 15, 2026
Comment thread .clang-format
@crtrott

crtrott commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Which .clang-format file did you use Please cherry-pick the enforcement from #473

Wasn't that done in #475 or so by Daniel which is already merged?

Comment thread .clang-format
Comment thread .pre-commit-config.yaml

@dalg24 dalg24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we like the config

@dalg24
dalg24 merged commit dbb0bd5 into kokkos:stable Oct 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants