[patch] Keep the patch-fixture -text rule out of the SDK-managed root .gitattributes - #134
Merged
matt-edmondson merged 1 commit intoSep 28, 2026
Conversation
… .gitattributes ktsu.Sdk regenerates the root .gitattributes on every build, which deleted the "GitIntegration.Test/Fixtures/patch-*.txt -text" rule and left the tree dirty after any dotnet build. Move the rule into GitIntegration.Test/Fixtures/.gitattributes, where the SDK does not touch it, and take the root file in the form the SDK writes. Fixes #132 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P1dENrzXtWG4vP7thSjyof
|
This was referenced Sep 27, 2026
matt-edmondson
deleted the
claude/gitintegration-132-fixture-gitattributes
branch
September 28, 2026 01:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132
Problem
ktsu.Sdk's
_KtsuSyncStyleConfigFilestarget regenerates the root.gitattributeson every build. That deletes theGitIntegration.Test/Fixtures/patch-*.txt -textrule protecting the mixed LF/CRLF patch fixtures. After anydotnet buildthe tree is dirty, and the deletion is easy to commit by accident.Change
GitIntegration.Test/Fixtures/.gitattributesaspatch-*.txt -text, with a comment explaining why it lives there..gitattributesis now exactly what the SDK writes, so building leaves it unchanged.Verification
Checked against the acceptance criteria in the issue:
main,dotnet buildremoves the rule.git check-attr text GitIntegration.Test/Fixtures/patch-crlf.txtthen reportsauto.dotnet buildleavesgit statusclean.git check-attr textreportsunsetforpatch-crlf.txtandpatch-new-file.txt, and other fixtures such asgithub-pullrequests.jsonstayauto.git add --renormalize .changes nothing.No unit test was added. The failure is in repository attributes, not in code, so the
git check-attrcheck above is the regression check.Separately, the SDK overwriting repository-specific attributes may deserve its own issue in ktsu-dev/Sdk, as the triage comment suggests. This PR does not address that.
🤖 Generated with Claude Code
https://claude.ai/code/session_01P1dENrzXtWG4vP7thSjyof
Generated by Claude Code