Scan silently skips images in dot-folders and dot-named files (and Hidden/System files on Windows) since the unreadable-folder fix

[matt-edmondson]

What's wrong

ImageScanner.ScanForImages (ImageDescriber/ImageScanner.cs:34-43) switched from the SearchOption.AllDirectories overload to an EnumerationOptions instance so that unreadable folders are skipped (c66d467, #162):

EnumerationOptions options = new()
{
	RecurseSubdirectories = true,
	IgnoreInaccessible = true,
};

EnumerationOptions.AttributesToSkip defaults to FileAttributes.Hidden | FileAttributes.System, whereas the SearchOption overload skips nothing. On Linux and macOS .NET reports every .-prefixed file and directory as Hidden, so they are now excluded along with everything below them. On Windows, anything with the Hidden or System attribute is excluded.

Reproduced with .NET 10 on a tree containing root/.hidden/a.jpg, root/.c.png and root/vis/b.jpg:

• the old Directory.EnumerateFiles(root, "*", SearchOption.AllDirectories) returns all 3 files
• the current code returns only vis/b.jpg

Why it matters

ImageDescriber Scan -p ~/Pictures quietly misses images under any dot-folder (e.g. .thumbnails, synced-app folders, .photoslibrary-style bundles) and any dot-named image. Nothing is logged; the "Found N image(s)" count is just lower, so users have no way to notice. The change was a side-effect of the #162 fix, not a deliberate behaviour change.

Suggested fix

Set AttributesToSkip = 0 (or FileAttributes.None) in the options, keeping IgnoreInaccessible = true. If skipping hidden content is actually wanted, make it an explicit, documented choice instead.

Acceptance criteria

• An image inside a .-prefixed directory and a .-prefixed image file under the scan root are both returned by ScanForImages.
• Unreadable folders are still skipped (the Scan crashes with an unhandled UnauthorizedAccessException, describing nothing, when any subfolder of the scanned tree is unreadable #162 behaviour is preserved).
• A test in ImageScannerTests covers both cases.

[matt-edmondson]

Triage

• Category: Bug (regression from Scan crashes with an unhandled UnauthorizedAccessException, describing nothing, when any subfolder of the scanned tree is unreadable #162 / c66d467)
• Priority: Medium. Images under dot-folders are silently left out of scans, with nothing logged. The fix is one line (AttributesToSkip = 0).
• Area / suggested assignment: ImageScanner.ScanForImages
• Related: Edited, moved or deleted images keep their old description: Scan only ever adds to KnownPaths and never prunes stale paths #176. Its prune step would treat these skipped files as deleted, so fix this first.
• Duplicates: none found.
• In progress: no. The open PR fix: return non-zero exit code when commands fail #173 is about exit codes.

---

Generated by Claude Code