Scan image files whose extensions are upper-case - #152
Merged
Merged
Conversation
ImageScanner matched extensions against a lower-case set using FileExtension's ordinal equality, so .JPG, .PNG and .JPEG files were silently skipped. Lower the extension before the lookup. Fixes #148 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0113g7mUxeizhTrH6na279Ez
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148
Summary
ImageScanner.ScanForImageslooked up each file's extension in a lower-caseHashSet<FileExtension>, andFileExtensionequality is ordinal. Files namedIMG_0001.JPG,x.Pngory.JPEGwere skipped on every OS. The fix lowers the extension withToLowerInvariant()before the lookup.Test
ScanForImagesMatchesExtensionsCaseInsensitively:.JPG,.Png,.jpegand.TIFFfiles must all be returned, andNOTES.TXTmust not be.🤖 Generated with Claude Code
https://claude.ai/code/session_0113g7mUxeizhTrH6na279Ez
Generated by Claude Code