Skip unreadable folders when scanning for images [patch] - #168
Merged
Merged
Conversation
Directory.EnumerateFiles with SearchOption.AllDirectories throws on the first subfolder it can't open, so a scan of a Windows drive or profile root died before describing anything. Enumerate with IgnoreInaccessible so those folders are skipped and the rest of the tree is scanned. Fixes #162 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtRTdtw1SbV7ugjz5wPFgc
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162
What changed
ImageScanner.ScanForImagesenumerated withSearchOption.AllDirectories. That overload leavesIgnoreInaccessibleoff, so the first subfolder it couldn't open threwUnauthorizedAccessExceptionand killed the whole scan before anything was described. On Windows that happens for any drive root or user-profile root, which are the usual targets.It now enumerates with
EnumerationOptions { RecurseSubdirectories = true, IgnoreInaccessible = true }. Unreadable folders are skipped and the rest of the tree is scanned.Test
ScanForImagesSkipsUnreadableSubdirectoriescreatesreadable.jpgnext to alocked/folder with mode000and expects only the readable image back.nobody): it fails without the fix (UnauthorizedAccessException: Access to the path '.../locked' is denied) and passes with it.000folder. GitHub's Linux runners run as a non-root user, so CI exercises it.Full suite locally: 46 passed, 1 skipped (this test, because the local run was as root).
🤖 Generated with Claude Code
https://claude.ai/code/session_01QtRTdtw1SbV7ugjz5wPFgc
Generated by Claude Code