Show a numbered menu off Windows instead of crashing [patch] - #170
Merged
Merged
Conversation
The default Menu verb displays a DustInTheWind ScrollMenu, which reads Console.CursorVisible. .NET only supports that on Windows, so running ImageDescriber with no arguments, or an unknown verb, crashed with PlatformNotSupportedException on Linux and macOS. Off Windows, list the verbs as numbered choices read from standard input, and stop at end of input. Fixes #165 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtRTdtw1SbV7ugjz5wPFgc
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #165
What changed
Menuis the default verb. It displays a DustInTheWindScrollMenu, which readsConsole.CursorVisible, and .NET only supports that on Windows. SoImageDescriberwith no arguments, or with an unknown verb, died withPlatformNotSupportedException(exit 134) on Linux and macOS.ScrollMenu.Menu.RunPromptMenu) lists the other verbs plus Exit and reads the choice from standard input:CreateMenuItem, so both menus share it.On Linux, the built binary with no arguments now shows:
Tests
New
MenuTests.cs:RunWithoutArgumentsOffersMenuOffWindowsruns the realMenuverb with stdin and stdout redirected. WithMenu.csreverted, it fails withSystem.PlatformNotSupportedException: Operation is not supported on this platform.With the fix, it passes. It is Inconclusive on Windows, where theScrollMenuneeds a real console.PromptMenuRunsTheChosenItemUntilExit,PromptMenuRejectsInvalidChoicesandPromptMenuStopsAtEndOfInputcover the prompt loop.Full suite: 50 passed.
The triage note links this to #167 (non-zero exit codes). This PR doesn't touch exit codes; the menu path has no error exit of its own.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QtRTdtw1SbV7ugjz5wPFgc
Generated by Claude Code