Guard blank command ids in the active-profile lookup overloads

Keybinding.Test/BlankCommandIdTests.cs

@@ -0,0 +1,41 @@
+// Copyright (c) 2023-2026 ktsu-dev contributors
+
+namespace ktsu.Keybinding.Test;
+
+using ktsu.Keybinding.Core.Services;
+
+[TestClass]
+public class BlankCommandIdTests
+{
+	private ProfileManager _profiles = null!;
+	private KeybindingService _service = null!;
+
+	[TestInitialize]
+	public void Setup()
+	{
+		_profiles = new ProfileManager();
+		_profiles.CreateProfile("p", "Profile");
+		_service = new KeybindingService(new CommandRegistry(), _profiles);
+	}
+
+	[TestMethod]
+	[DataRow("")]
+	[DataRow("  ")]
+	[DataRow(null)]
+	public void ActiveProfileOverloads_BlankCommandId_MatchTheProfileIdOverloads(string? commandId)
+	{
+		Assert.IsNull(_service.GetChord(commandId!));
+		Assert.IsFalse(_service.UnbindChord(commandId!));
+		Assert.IsFalse(_service.HasChordBinding(commandId!));
+
+		_profiles.SetActiveProfile("p");
+
+		Assert.IsNull(_service.GetChord(commandId!), "GetChord should not depend on whether a profile is active.");
+		Assert.IsFalse(_service.UnbindChord(commandId!), "UnbindChord should not depend on whether a profile is active.");
+		Assert.IsFalse(_service.HasChordBinding(commandId!), "HasChordBinding should not depend on whether a profile is active.");
+
+		Assert.AreEqual(_service.GetChord("p", commandId!), _service.GetChord(commandId!));
+		Assert.AreEqual(_service.UnbindChord("p", commandId!), _service.UnbindChord(commandId!));
+		Assert.AreEqual(_service.HasChordBinding("p", commandId!), _service.HasChordBinding(commandId!));
+	}
+}

Keybinding/Services/KeybindingService.cs

@@ -36,7 +36,7 @@
 			throw new ArgumentException("Profile ID cannot be null or whitespace", nameof(id));
 		}
 
 		ArgumentException.ThrowIfNullOrWhiteSpace(name, nameof(name));
 
 		return _profileManager.CreateProfile(id, name, description);
 	}
@@ -89,6 +89,11 @@
 	/// <inheritdoc/>
 	public Chord? GetChord(string commandId)
 	{
+		if (string.IsNullOrWhiteSpace(commandId))
+		{
+			return null;
+		}
+
 		Profile? activeProfile = _profileManager.GetActiveProfile();
 		return activeProfile?.GetChord(commandId);
 	}
@@ -127,6 +132,11 @@
 	/// <inheritdoc/>
 	public bool UnbindChord(string commandId)
 	{
+		if (string.IsNullOrWhiteSpace(commandId))
+		{
+			return false;
+		}
+
 		Profile? activeProfile = _profileManager.GetActiveProfile();
 		return activeProfile?.RemoveChord(commandId) ?? false;
 	}
@@ -249,6 +259,11 @@
 	/// <inheritdoc/>
 	public bool HasChordBinding(string commandId)
 	{
+		if (string.IsNullOrWhiteSpace(commandId))
+		{
+			return false;
+		}
+
 		Profile? activeProfile = _profileManager.GetActiveProfile();
 		return activeProfile?.HasChord(commandId) ?? false;
 	}