Scanning or adding a GitHub owner crashes on a 404/401/rate limit instead of skipping the owner

[matt-edmondson]

What's wrong

SyncGitHubRepoInfoForOwner (ProjectDirector/ProjectDirector.cs ~L1006, L1010) fetches repos with .Result:

IEnumerable<Repository> remoteRepos = GitHubClient.Repository.GetAllForUser(owner).Result;
...
remoteRepos = remoteRepos.Concat(GitHubClient.Repository.GetAllForOrg(owner).Result);

and guards it with catch (ApiException) { // skip this owner }. But .Result wraps failures in AggregateException, so the ApiException handler never matches and the error escapes.

The step before it, SyncGitHubOwnerInfo (~L990), calls GitHubClient.User.Get(owner).GetAwaiter().GetResult() with no handler at all, so a 404 there also escapes.

Failure scenario

• "Add New GitHub Owner" with a typo, or
• "Scan > GitHub Owners" when a saved owner was renamed or deleted, its PAT was revoked, or the API rate limit is used up

→ NotFoundException / AuthorizationException / RateLimitExceededException (wrapped in AggregateException in the repo-listing path) comes out of an ImGui menu/popup callback on the render thread. The scan stops partway, and the app probably goes down with it. The owner has already been added to Options.GitHubOwners. If that was saved, every later owner scan fails the same way, and there is no UI to remove the owner.

Verified with a scratch test that points Octokit's GitHubClient at a local HttpListener returning 404:

• GetAllForUser("nobody").Result threw System.AggregateException (inner Octokit.NotFoundException), and catch (Octokit.ApiException) did not catch it.
• User.Get(...).GetAwaiter().GetResult() threw Octokit.NotFoundException.

Suggested fix

• Replace .Result with .GetAwaiter().GetResult() (or await) so ApiException is thrown unwrapped.
• Move the User.Get call into the same guarded region, or catch ApiException in SyncGitHubOwnerInfo too. Also catch HttpRequestException so going offline is handled.
• Log the skipped owner and the reason rather than swallowing it silently.
• Related: the "Add New GitHub Owner" path calls SyncGitHubOwnerInfo without ApplyCredentials first, so the new owner is queried with whatever credentials the previous scan left on the shared client. This is the same leak GitHub credentials from one owner leak into the scan of the next, misdirecting private-repo lookups #426 fixed for the scan loop.

Acceptance criteria

• Adding a nonexistent owner, or scanning with one owner returning 404/401/403 or a rate-limit error, logs a message, skips that owner, and carries on with the rest.

[matt-edmondson]

Triage

• Category: Bug
• Priority: High. An ordinary condition (a typo in an owner name, a renamed or deleted owner, a revoked PAT, an exhausted rate limit) throws out of an ImGui callback on the render thread and likely takes the app down. Once a bad owner is saved, every later owner scan fails the same way, and the UI has no way to remove it.
• Area: SyncGitHubOwnerInfo / SyncGitHubRepoInfoForOwner (Octokit calls using .Result)
• Suggested assignment: ProjectDirector GitHub-sync owner. They handled GitHub credentials from one owner leak into the scan of the next, misdirecting private-repo lookups #426, which fixed the related credential leak in the scan loop.
• Duplicates / related: Not a duplicate. It is related to GitHub credentials from one owner leak into the scan of the next, misdirecting private-repo lookups #426: the "Add New GitHub Owner" path still skips ApplyCredentials. After "Scan GitHub Owners", repos found by "Scan Dev Dir" point at a nonexistent folder, fail a fetch every minute, and show broken Pull/Commit/Push #438 is a separate owner-scan bug in the same area.
• Already in progress: No open PR addresses this.
• Next step: Switch to .GetAwaiter().GetResult() or await, and guard User.Get as well. Catch ApiException and HttpRequestException, log the skipped owner, and call ApplyCredentials on the add-owner path. Consider adding a way to remove a saved owner.

---

Generated by Claude Code