Skip to content

Include <compare> in a generated semantic type #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-edmondson merged 1 commit into from
Sep 14, 2026
Merged

Include <compare> in a generated semantic type #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Schema.Cpp.Test/ExemplarSemanticTypeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ public sealed class ExemplarSemanticTypeTests

#pragma once

#include <compare>
#include <cstdint>
#include <type_traits>

Expand Down
7 changes: 7 additions & 0 deletions Schema.Cpp/CppFileBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,13 @@ public SourceFile SemanticType(SchemaSemanticType semanticType)
}

declaration.Members.Add(Comparison(name, "==", "bool"));

// A defaulted <=> answers with one of the ordering types, and those live in <compare>.
// libstdc++ happens to have declared them by the time this header is read and libc++ does
// not, so without this the generated type compiles under GCC and is refused by Clang -
// which is exactly the kind of difference a generator must not leave to whoever includes
// it.
mapper.Require("<compare>");
declaration.Members.Add(Comparison(name, "<=>", "auto"));
declaration.Members.Add(new FieldDeclaration(ValueField, UnderlyingAlias) { Visibility = Visibility.Private });

Expand Down
Loading