Fix: Format tests/test_docs_pipeline.py to pass ruff checks - #235
Fix: Format tests/test_docs_pipeline.py to pass ruff checks#235Fumer057 wants to merge 1 commit into
Conversation
Signed-off-by: Fumer057 <fumer057@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ArshVermaGit
left a comment
There was a problem hiding this comment.
This is only a formatting change (removing one blank line), but the PR does not show a meaningful code-level fix. I would not approve this PR as-is.
|
@ArshVermaGit: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @ArshVermaGit, thanks for the review! I understand this looks minimal, but this single trailing-newline removal is the exact output of The and fails with: This means every new PR against Happy to discuss further or make any additional changes if needed! |
|
Hi @Fumer057 did you create tracking issue for this? |
ArshVermaGit
left a comment
There was a problem hiding this comment.
Looks good. This removes only the trailing blank line that ruff format --check flags, so the change is minimal and directly fixes the CI formatting failure. No further changes needed.
Problem
Fixes #236
The
PR Safetyworkflow is failing on the "Check formatting" step becausetests/test_docs_pipeline.pydoes not meet ruff's code formatting standards.Failure Details
.github/workflows/tests.yml- "PR Safety"ruff format --check docs-agent-mcp/mcp-server testsfound 1 file that would be reformattedtests/test_docs_pipeline.pyRoot Cause
The test file has a trailing blank line at the end that doesn't comply with ruff's formatting standards. The workflow enforces code formatting to maintain consistency across the codebase.
Solution
Applied
ruff formattotests/test_docs_pipeline.pyto bring it into compliance with project formatting standards. This is the exact output of runningruff format— no other changes.Contributing Guidelines Followed
Testing
All checks pass:
ruff check .(lint check)ruff format --check docs-agent-mcp/mcp-server tests(formatting check)pytest -v --tb=short(unit tests)Type