fix(chart): set unhealthyPodEvictionPolicy on the PDB - #487
DsThakurRawat wants to merge 1 commit into
Conversation
Render unhealthyPodEvictionPolicy (default AlwaysAllow) into the PodDisruptionBudget so unhealthy pods do not block voluntary evictions indefinitely. Gated on clusters >= 1.27 where the field is supported and omitted when empty. Covered by helm-unittest. Signed-off-by: Divyansh Rawat <divyanshrawatofficial@gmail.com>
✅ Deploy Preview for node-readiness-controller canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DsThakurRawat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @DsThakurRawat. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This looks good to me |
Description
Sets
unhealthyPodEvictionPolicy(defaultAlwaysAllow) on the chart's PodDisruptionBudget so unhealthy pods do not block voluntary evictions indefinitely. Rendered only on clusters >= 1.27 where the field is supported, and omitted when empty. Found via kube-linter on the fully-rendered chart.Related Issue
None
Type of Change
/kind feature
Testing
helm unittest --strict: 43/43 pass (5 runs), including 2 new PDB caseshelm lint: cleanhelm templateon kube 1.25/1.26 omits the field, on 1.29 renders ithack/verify-chart-drift.shcleanChecklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?
Generative AI Usage Disclosure
How they were used:
AI assistance drafted the template stanza, values/docs rows, and unittest cases. Every line was verified by local runs before pushing: helm unittest (5x), lint, multi-version template renders, kube-linter, chart drift check.