Improved support for Rive files - #182
Open
kunitoki wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (65.86%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 81.49% 81.41% -0.08%
==========================================
Files 798 805 +7
Lines 83336 84278 +942
==========================================
+ Hits 67911 68612 +701
- Misses 15425 15666 +241
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces major enhancements to the Rive artboard integration, focusing on responsive layout, data binding (ViewModel) support, and improved demo examples. It also adds new configuration options and controls for the artboard demo, making it more interactive and feature-rich. Additionally, it includes updates to documentation and build configuration to support new assets and clarify coding guidelines.
Rive Artboard Features and API Enhancements:
Artboard, including per-node bounds listeners and component attachment APIs (setNodeBoundsListener,attachComponentToNode, etc.), enabling components to track node bounds and transformations in real time.Artboard::setFile()now supports loading a named artboard from a file, not just the default.Demo and Example Improvements:
Artboard.h): added a base class (ArtboardDemoBase), aNodeMarkercomponent for visualizing node tracking, and new UI controls for marker behavior (fill/track, pivot, anchor, transform). [1] [2] [3] [4] [5] [6]ArtboardLayoutDemoexample, which demonstrates attaching a live, nested artboard to a layout node in another artboard.layout-ui.rivasset required by the new demo. [1] [2]Testing and Documentation:
AGENTS.mdandCLAUDE.mdto instruct AI assistants to avoid adding obvious comments and instead write more expressive code.Performance and Code Quality:
SDLComponentNativenow caches its window units-per-point value, reducing render thread calls to SDL window methods.These changes collectively improve the flexibility, interactivity, and test coverage of the Rive artboard integration, while making the demo codebase more maintainable and expressive.