Repository navigation
Use Inertia links, paginate projects, drop unused shadcn packages - #6
Merged
Merged
Conversation
phpunit.xml set DB_DATABASE=:memory: as a plain <env>, which loses to an existing environment variable, and Laravel reads $_SERVER before $_ENV anyway. With DB_DATABASE set in the shell (as on a server), `php artisan test` ran RefreshDatabase against the real database and emptied it — reproduced locally against a seeded SQLite file. Force the test env and add matching <server> entries so the tests always use the in-memory database. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Internal links were plain <a> tags, so every click reloaded the whole app; they are now Inertia <Link>s - The projects list was paginated server-side (20 per page) but showed no page links, so anything past the first 20 projects was unreachable - Remove radix-vue, class-variance-authority, clsx, tailwind-merge and lucide-vue-next: installed for shadcn-vue but never imported Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<a>tags, so every click reloaded the whole app. They are now Inertia<Link>s.Paginationcomponent renders Laravel's paginator links.radix-vue,class-variance-authority,clsx,tailwind-mergeandlucide-vue-next. They were installed for shadcn-vue but never imported (25 packages removed).phpunit.xmlsetDB_DATABASE=:memory:as a plain<env>, and Laravel reads$_SERVERfirst, so aDB_DATABASEset in the shell won. That madephp artisan testrunRefreshDatabaseagainst the real database. I reproduced it with a seeded SQLite file, which was emptied. The test settings are now forced, with<server>entries added. This fix is also cherry-picked into kv4u/MoveZ#5 so it doesn't wait on Add dashboard login and per-user data scoping #2.Test plan
php artisan test: 39 passed. Ran it withDB_DATABASEpointing at a seeded SQLite file; afterwards the file still has 3 users and 25 projects (before the fix it was emptied).npm run type-checkandnpm run buildare clean🤖 Generated with Claude Code