Skip to content

Simplify CSS - #49

Closed
kytta wants to merge 3 commits into
mainfrom
modern-css
Closed

Simplify CSS#49
kytta wants to merge 3 commits into
mainfrom
modern-css

Conversation

@kytta

@kytta kytta commented Mar 20, 2023

Copy link
Copy Markdown
Owner

This PR remakes the whole CSS used in the package.

  • old position: absolute hacks get replaced with Flexbox
  • the variables and calc()s aren't compiled away any more, but exposed. This makes the CSS a bit heavier, but it allows very easy customization
  • instead of PostCSS, Lightning CSS is now used to minify styles. It's way faster and more effective, and it doesn't need plugins to operate.

Overall, the appearance of the buttons has become way more customizable. One can make the buttons vertical with a single line of CSS, change their radius and size, and more!

What else I want to do:

@kytta kytta added the enhancement New feature or request label Mar 20, 2023
@kytta kytta self-assigned this Mar 20, 2023
@github-actions

github-actions Bot commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

size-limit report 馃摝

Path Size
./dist/shareon.min.css 5.65 KB (+1.55% 馃敽)
./dist/shareon.es.js 914 B (0%)

@kytta

kytta commented Jul 18, 2023

Copy link
Copy Markdown
Owner Author

Surpassed by #74

@kytta kytta closed this Jul 18, 2023
@kytta
kytta deleted the modern-css branch July 19, 2023 21:44
@kytta
kytta restored the modern-css branch July 19, 2023 21:45
@kytta
kytta deleted the modern-css branch July 19, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant