fix(prompt): preserve empty fallback values - #1828
Open
jstar0 wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a prompt fetch fails, an explicitly supplied empty-string fallback is currently treated as if no fallback was provided because the fallback branch uses a truthiness check. This causes the client to raise instead of returning the caller's intentional empty fallback.
This changes the guard to an explicit
fallback is not Nonecheck, preserving existing behavior for omitted fallbacks while allowing""as a valid fallback value.Type of change
Verification
tests/unit/test_prompt.py: 27 passed (with proxy variables cleared and non-sensitive test credentials used for client initialization)ruff check langfuse tests/unit/test_prompt.py: passedgit diff --check origin/main...HEAD: passedChecklist
code_review.md..env.templateif needed.Greptile Summary
This PR preserves explicitly supplied empty prompt fallbacks when remote prompt retrieval fails.
Nonecheck.Confidence Score: 5/5
The PR appears safe to merge with no actionable correctness, security, or quality issues identified.
The updated guard preserves omitted-fallback behavior while allowing both empty strings and empty chat lists supported by the declared prompt models.
Reviews (1): Last reviewed commit: "fix(prompt): preserve empty fallback val..." | Re-trigger Greptile