Skip to content

fix(just): fail merge-method-rollout on misplaced named arguments - #530

Open
laurigates wants to merge 1 commit into
mainfrom
fix/merge-method-rollout-args
Open

laurigates wants to merge 1 commit into
mainfrom
fix/merge-method-rollout-args

Conversation

@laurigates

Copy link
Copy Markdown
Owner

just passes recipe arguments by position, so the documented just -g merge-method-rollout apply=true set owner to apply=true. gh repo list returned no repos, and the recipe printed REPOS=0 and STATUS=OK without opening anything.

  • Exit 1 when the owner has no source repos, or when apply is neither true nor false.
  • The usage comment and the dry-run hint now show the positional form, just -g merge-method-rollout laurigates 90 true.

Checked against this branch's git.just:

Invocation Result
merge-method-rollout apply=true rc=1, no source repos for owner 'apply=true' (arguments are positional: owner days apply)
merge-method-rollout laurigates 90 yes rc=1, apply must be true or false, got 'yes'
merge-method-rollout (dry run) rc=0, REPOS=49

🤖 Generated with Claude Code

https://claude.ai/code/session_01JkCD99DhhasECZzSq8UdGn

@github-actions github-actions Bot added size/s merge:squash Merge with Squash and merge labels Oct 27, 2026
just passes recipe arguments by position, so the documented `apply=true` became the owner. gh repo list returned no repos and the recipe printed REPOS=0 and STATUS=OK. It now exits 1 when the owner has no source repos or apply is not true/false, and the usage comment and dry-run hint show the positional form.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JkCD99DhhasECZzSq8UdGn
@laurigates
laurigates force-pushed the fix/merge-method-rollout-args branch from 62374bc to 150db11 Compare October 27, 2026 10:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge:squash Merge with Squash and merge size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant