Fix ConcurrentModificationException in View draw loops - #130
Open
leniver wants to merge 1 commit into
Open
Conversation
View#drawSelf, #drawHidden and #drawSelfLast iterated the live children list. A structural change to that list during a render pass crashed the client with ConcurrentModificationException. View#onUpdate already guarded against this by iterating a copy; apply the same treatment to the three draw paths. Fixes ldtteam#129
|
|
Contributor
|
Fill in the pull request template accordingly. |
Author
|
I've updated the pull request to match the template. |
Raycoms
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129
Changes proposed in this pull request
View#drawSelf,#drawHiddenand#drawSelfLastiterated the livechildrenlist, so a structural change to it during a render pass crashed the client withConcurrentModificationException. Stack and analysis are in ConcurrentModificationException in View#drawSelf when children are modified during rendering #129.View#onUpdatealready uses (new ArrayList<>(children)) to those three draw paths. Scope is kept to the per-frame draw methods;findPaneByID,findPaneByType,setWindowand the reverselistIteratorinmouseEventProcessorare left as-is. Happy to widen it if you would prefer the whole class handled at once.Testing