WIP: Port BlockUI to Minecraft 26.2 - #131
Closed
MrFruitDude wants to merge 1 commit into
Closed
Conversation
|
|
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP / review disclaimer
This is a coordinated work-in-progress port to Minecraft 26.2. The game starts and core logic works, but crashes and texture/rendering mismatches remain under active investigation. It is not ready to merge.
Changes
EntityIconstates render with the defaultAvatarRenderStateinstead of throwing during GUI construction.Change map (96 changed files)
src/main/javasrc/main/resourcesKey review files:
controls/EntityIcon,controls/ItemIcon,mod/item/BlockStatePipRenderer,BOGuiGraphics,UiRenderMacros, andLoader.Validation
./gradlew buildsucceeds.minecolonies-26.2-testprofile reaches block-atlas creation with no fatal startup exception.TODO audit
The coordinated scan found 32 TODO/FIXME/XXX markers in tracked BlockUI source (excluding generated/build/runtime output). The avatar and empty-slot crash paths are addressed here; remaining port/render TODOs stay visible for follow-up.
Show-me / dependency graph
The review map follows the show-me skill: short prose, focused ownership boundaries, and diagrams for the dependency/control flow.
Companion PRs
This draft is part of the coordinated MineColonies 26.2 port. Review and test these together:
Standards
Draft only; repository issue/CLA requirements and maintainer review still apply.
Base branch note
The upstream repository does not currently publish a
version/26.2branch. This PR is therefore based on the existing 26.xversion/26branch, while its head is the newport/26.2-wipbranch. It should be retargeted and rebased when maintainers cut the official 26.2 base.Do not merge this snapshot into
version/26; it is only a transport/review anchor untilversion/26.2exists.