fix: parse header as per http spec#1
Open
lego290 wants to merge 1 commit into
Open
Conversation
lego290
marked this pull request as ready for review
July 20, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (pls check at least one)
Description
The default implementation of the header handler retirns the contents of the Accept-Language header as it was sent without parsing it in any way. this makes the
lingo()->getCurrentLocale()return values likeen-US,en;q=0.9,zh-CN;q=0.8,zh;q=0.7.This pr updates the header handler to properly parse the Accept-Language heasder while also considering requested quality as per https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Accept-Language.
Does this PR introduce a breaking change? (check one)
Related Issue
Issues are disabled on this repository and the Discord link is invalid so i have not been able to create an issue or discuss it with you first. So im submitting this here instead.