Skip to content

Multi-target contracts projects (v10) #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saancreed merged 3 commits into from
Sep 10, 2026
Merged

Multi-target contracts projects (v10) #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4dfb0c
Decorate VersionSupport query with [AllowUnauthorized]
Saancreed Sep 10, 2026
e410310
Fix the exclusion in LeanCode.CodeAnalysis reference
Saancreed Sep 10, 2026
ca2471a
Multi-target contracts projects
Saancreed Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CQRS/LeanCode.CQRS.Annotations/LeanCode.CQRS.Annotations.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework />
<TargetFrameworks>net6.0;net8.0;net9.0;net10.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<ProjectReference
Include="../../Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.csproj"
Condition="'$(MSBuildProjectName)' != 'LeanCode.CodeAnalysis'
And '$(TargetFramework)' == 'net9.0'"
And '$(TargetFramework)' != 'netstandard2.0'"

@mishioo mishioo Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only not the particular version of netstandard is enough here? 🤔 2.1 is fine?

@Saancreed Saancreed Sep 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, netstandard2.1 is fine because our CodeAnalysis package itself targets netstandard2.1. Only referencing it in projects targeting older netstandards is a problem.

>
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
<OutputItemType>Analyzer</OutputItemType>
Expand Down
3 changes: 2 additions & 1 deletion src/Infrastructure/LeanCode.ForceUpdate.Contracts/LeanCode.ForceUpdate.Contracts.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Nullable>annotations</Nullable>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework />
<TargetFrameworks>net6.0;net8.0;net9.0;net10.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/Infrastructure/LeanCode.ForceUpdate.Contracts/VersionSupport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
using LeanCode.Contracts;
using LeanCode.Contracts.Security;

namespace LeanCode.ForceUpdate.Contracts;

[AllowUnauthorized]
public class VersionSupport : IQuery<VersionSupportDTO>
{
public PlatformDTO Platform { get; set; }
Expand Down
Loading