Skip to content

Multi-target contracts projects (v11) - #893

Merged
Saancreed merged 3 commits into
v11.0-previewfrom
contracts-multi-target-v11
Sep 14, 2026
Merged

Saancreed merged 3 commits into
v11.0-previewfrom
contracts-multi-target-v11

Conversation

@Saancreed

Copy link
Copy Markdown
Member

Frontport of #892 (is that even a word? 🤔), except with legacy net6.0 swapped for current net11.0.

@Saancreed

Copy link
Copy Markdown
Member Author

Right, obviously this depends on us actually starting to use .NET 11 🙈

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are small, consistent with the stated goal (multi-targeting and the VersionSupport fix), and no correctness or safety issues were found in the updated code/props.

Pull request overview

This PR frontports the “multi-target contracts projects” work to the v11 branch by updating selected contracts projects to build for multiple modern TFMs and adjusting shared build infrastructure accordingly.

Changes:

  • Multi-target LeanCode.ForceUpdate.Contracts and LeanCode.CQRS.Annotations for net8.0;net9.0;net10.0;net11.0.
  • Make VersionSupport explicitly opt out of authorization via [AllowUnauthorized].
  • Update src/Directory.Build.props so the LeanCode.CodeAnalysis analyzer project reference is enabled for all TFMs except netstandard2.0 (instead of only net9.0).
File summaries
File Description
src/Infrastructure/LeanCode.ForceUpdate.Contracts/VersionSupport.cs Marks the VersionSupport query as explicitly allowed without authorization.
src/Infrastructure/LeanCode.ForceUpdate.Contracts/LeanCode.ForceUpdate.Contracts.csproj Switches the contracts project to multi-target net8.0 through net11.0.
src/Directory.Build.props Broadens analyzer inclusion condition to run for all non-netstandard2.0 targets.
src/CQRS/LeanCode.CQRS.Annotations/LeanCode.CQRS.Annotations.csproj Switches the annotations contracts project from single-target net6.0 to multi-target net8.0 through net11.0.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Saancreed
Saancreed force-pushed the contracts-multi-target-v11 branch from 710d7f7 to f11a0b4 Compare September 10, 2026 14:18
@github-actions

Copy link
Copy Markdown

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
947 946 0 1 0 0 1m 54s

Skipped

Tests Status
LeanCode.Azure.Tests.AzureStorageAuditLogIntegrationTests.Ensure_that_all_logs_are_correctly_uploaded_to_multiple_files skipped ⏭️

🎉 No failed tests in this run.

Github Test Reporter by CTRF 💚

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.41%. Comparing base (90f57bf) to head (f11a0b4).

Additional details and impacted files
@@              Coverage Diff               @@
##           v11.0-preview     #893   +/-   ##
==============================================
  Coverage          85.41%   85.41%           
==============================================
  Files                246      246           
  Lines               5210     5210           
  Branches             385      385           
==============================================
  Hits                4450     4450           
  Misses               676      676           
  Partials              84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Saancreed
Saancreed added this pull request to stack #895 September 14, 2026 10:01
@Saancreed
Saancreed merged commit 5c508b9 into v11.0-preview Sep 14, 2026
8 checks passed
@Saancreed
Saancreed deleted the contracts-multi-target-v11 branch September 14, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants