Repository navigation
Multi-target contracts projects (v11) - #893
Conversation
Only LeanCode.DomainModels.Generators should not reference it.
|
Right, obviously this depends on us actually starting to use .NET 11 🙈 |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, consistent with the stated goal (multi-targeting and the VersionSupport fix), and no correctness or safety issues were found in the updated code/props.
Pull request overview
This PR frontports the “multi-target contracts projects” work to the v11 branch by updating selected contracts projects to build for multiple modern TFMs and adjusting shared build infrastructure accordingly.
Changes:
- Multi-target
LeanCode.ForceUpdate.ContractsandLeanCode.CQRS.Annotationsfornet8.0;net9.0;net10.0;net11.0. - Make
VersionSupportexplicitly opt out of authorization via[AllowUnauthorized]. - Update
src/Directory.Build.propsso theLeanCode.CodeAnalysisanalyzer project reference is enabled for all TFMs exceptnetstandard2.0(instead of onlynet9.0).
File summaries
| File | Description |
|---|---|
| src/Infrastructure/LeanCode.ForceUpdate.Contracts/VersionSupport.cs | Marks the VersionSupport query as explicitly allowed without authorization. |
| src/Infrastructure/LeanCode.ForceUpdate.Contracts/LeanCode.ForceUpdate.Contracts.csproj | Switches the contracts project to multi-target net8.0 through net11.0. |
| src/Directory.Build.props | Broadens analyzer inclusion condition to run for all non-netstandard2.0 targets. |
| src/CQRS/LeanCode.CQRS.Annotations/LeanCode.CQRS.Annotations.csproj | Switches the annotations contracts project from single-target net6.0 to multi-target net8.0 through net11.0. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
710d7f7 to
f11a0b4
Compare
Summary
Skipped
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v11.0-preview #893 +/- ##
==============================================
Coverage 85.41% 85.41%
==============================================
Files 246 246
Lines 5210 5210
Branches 385 385
==============================================
Hits 4450 4450
Misses 676 676
Partials 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Frontport of #892 (is that even a word? 🤔), except with legacy
net6.0swapped for currentnet11.0.