Repository navigation
Lock workflow dependencies and stop running tests on tag pushes - #589
Open
PiotrRogulski wants to merge 1 commit into
Open
PiotrRogulski wants to merge 1 commit into
PiotrRogulski wants to merge 1 commit into
Conversation
Each package's test workflow had `tags-ignore` for its own tags, so a release tag of one package matched every other package's test workflow. GitHub doesn't apply `paths` filters to tag pushes, so all of them ran. Without `tags-ignore`, `branches: [master]` keeps tag pushes out. Pin every action, including the actions that composite actions use, in .github/workflows/actions.lock, and reference actions by full release tags. A new lockfile workflow runs `gh actions-lock --verify` on pull requests that change a workflow, and Dependabot now also updates the actions, which updates the lockfile in the same pull request. Bump actions/checkout to v7.0.1, dart-lang/setup-dart to v1.8.1, subosito/flutter-action to v2.23.0, actions/cache to v6.1.0, actions/labeler to v7.0.0, codecov/codecov-action to v7.1.1 and the pana-score action to pana-score-v1.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PiotrRogulski
marked this pull request as ready for review
October 23, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests no longer run on tag pushes
Pushing a release tag ran the test workflow of every other package. When
leancode_lint-v28.0.0was pushed, 18 test workflows ran and 8 of them failed. Each*-test.ymlhadtags-ignore: ['<package>-v*']underpush, so every other package's tag matched it, and GitHub doesn't applypathsfilters to tag pushes. This removestags-ignorefrom all 18 workflows. With onlybranches: [master]left, tag pushes no longer start test workflows. Pushes to master already ran only the tests of the package that changed, and they still do.Workflow lockfile
This adopts workflow dependency lockfiles, which are in public preview.
.github/workflows/actions.lock, written bygh actions-lockv0.3.0, pins every action that the 38 workflows use to a commit, including the 7 actions that composite actions use, such asmikefarah/yq@masterfrompub-release.uses:lines name full release tags, such asactions/checkout@v7.0.1, instead of floating tags (@v3) or commit SHAs. The lockfile pins the commits.lockfileworkflow runsgh actions-lock --verifyon pull requests that change.github/workflows/, as the enforcement guide suggests..gitattributesmarks the lockfile aslinguist-generated, so its diff is collapsed in pull requests.Version bumps
actions/checkoutv3,v4, v4.4.0 SHAv7.0.1dart-lang/setup-dartv1v1.8.1subosito/flutter-actionv2v2.23.0actions/cachev4v6.1.0actions/labelerv5v7.0.0codecov/codecov-actionv1v7.1.1pana-scorepana-score-v1.3Before merging
CODECOV_TOKENsecret, unless the organization allows tokenless uploads for public repositories in its Codecov settings. Without either, the upload step logs an error but doesn't fail the job.pull_request_target. The labeler only checks out the base branch, so it should be unaffected, but this hasn't been tested.Testing
gh actions-lock --verifyprints "All 38 workflows valid" on this branch. Thelockfileworkflow and every package's test workflow run on this pull request, because it changes each of their files.🤖 Generated with Claude Code