Skip to content

install.xml: Pass core test test_db_install_file - #319

Merged
bluetom merged 1 commit into
learnweb:develop502from
jrchamp:fix/db-install-xml
Aug 19, 2026
Merged

install.xml: Pass core test test_db_install_file#319
bluetom merged 1 commit into
learnweb:develop502from
jrchamp:fix/db-install-xml

Conversation

@jrchamp

@jrchamp jrchamp commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

🔀 Purpose of this PR:

  • Fixes a bug
  • Updates for a new Moodle version
  • Adds a new feature of functionality
  • Improves or enhances existing features
  • Refactoring: restructures code for better performance or maintainability
  • Testing: add missing or improve existing tests
  • Miscellaneous: code cleaning (without functional changes), documentation, configuration, ...

📝 Description:

Moodle core has a group of checks that are relevant for plugins and the only one that fails for tool_lifecycle is test_db_install_file. This PR fixes that issue so that tool_lifecycle passes the plugin_checks group cleanly.


📋 Checklist

Please confirm the following (check all that apply):

  • I have phpunit and/or behat tests that cover my changes or additions.
  • Code passes the code checker without errors and warnings.
  • Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.
  • Code only uses language strings instead of hard-coded strings.
  • [N/A] If there are changes in the database: I updated/created the necessary upgrade steps in db/upgrade.php and
    updated the version.php.
  • [N/A] If there are changes in javascript: I build new .min files with the grunt amd command.
  • [N/A] If it is a Moodle update PR: I read the release notes, updated the version.php and the CHANGES.md.
    I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
    changes in the plugins UI.

🔍 Related Issues


@bluetom
bluetom changed the base branch from main to develop502 August 18, 2026 13:51
@bluetom
bluetom merged commit 03fd4ca into learnweb:develop502 Aug 19, 2026
15 checks passed
@jrchamp
jrchamp deleted the fix/db-install-xml branch August 19, 2026 10:49
bluetom added a commit that referenced this pull request Aug 27, 2026
Co-authored-by: Jonathan Champ <royanee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing core unit test due to install.xml file

2 participants