Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/csv.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { Database } from "bun:sqlite";
import { formatCents } from "./money/cents.ts";

interface ExpenseRow {
createdAt: string;
Expand All @@ -25,20 +26,12 @@ function fetchExpenseRows(db: Database, groupId: string): ExpenseRow[] {
.all(groupId) as ExpenseRow[];
}

/**
* Build the CSV export for a group's expenses.
*
* SEEDED DEFECT (issue #3): the amount column prints the raw integer cents
* (e.g. "1000") instead of a formatted amount ("10.00"). Baseline tests
* only check the header row and the row count, not the amount column's
* formatting, so this ships undetected. The fix should reuse
* `formatCents` from src/money (see .claude/skills/handling-money).
*/
/** Build the CSV export for a group's expenses; amounts are formatted at this edge (1000 -> "10.00"). */
export function exportCsv(db: Database, groupId: string): string {
const rows = fetchExpenseRows(db, groupId);
const header = "date,payer,description,amount\n";
const lines = rows.map(
(r) => `${r.createdAt},${csvEscape(r.payerName)},${csvEscape(r.description)},${r.amountCents}`,
(r) => `${r.createdAt},${csvEscape(r.payerName)},${csvEscape(r.description)},${formatCents(r.amountCents)}`,
);
return header + lines.join("\n") + (lines.length > 0 ? "\n" : "");
}
72 changes: 72 additions & 0 deletions tests/csv.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import { Database } from "bun:sqlite";
import { describe, expect, test } from "bun:test";
import { exportCsv } from "../src/csv.ts";
import { initSchema } from "../src/db.ts";
import { createExpense } from "../src/expenses.ts";
import { seedDemoData } from "../src/seed.ts";

function setupDb(): Database {
const db = new Database(":memory:");
initSchema(db);
seedDemoData(db);
return db;
}

function amountColumn(csv: string): string[] {
return csv
.trim()
.split("\n")
.slice(1)
.map((line) => line.split(",").at(-1) ?? "");
}

describe("exportCsv", () => {
test("formats a 1000-cent expense as 10.00", () => {
const db = setupDb();
createExpense(db, {
groupId: "flat-4b",
payerId: "flat-priya-id",
amountCents: 1000,
description: "Milk",
splitAmong: ["flat-priya-id"],
createdAt: "2026-10-01T09:00:00.000Z",
});
const lines = exportCsv(db, "flat-4b").trim().split("\n");
expect(lines.at(-1)).toBe("2026-10-01T09:00:00.000Z,Priya,Milk,10.00");
});

test("formats non-round cent amounts with two decimals", () => {
const db = setupDb();
[1005, 7].forEach((amountCents, i) => {
createExpense(db, {
groupId: "flat-4b",
payerId: "flat-priya-id",
amountCents,
description: `Odd ${i}`,
splitAmong: ["flat-priya-id"],
createdAt: `2026-10-0${i + 1}T09:00:00.000Z`,
});
});
expect(amountColumn(exportCsv(db, "flat-4b")).slice(-2)).toEqual(["10.05", "0.07"]);
});

test("formats an amount under one dollar with a leading zero", () => {
const db = setupDb();
createExpense(db, {
groupId: "flat-4b",
payerId: "flat-priya-id",
amountCents: 5,
description: "Sweet",
splitAmong: ["flat-priya-id"],
createdAt: "2026-10-01T09:00:00.000Z",
});
const lines = exportCsv(db, "flat-4b").trim().split("\n");
expect(lines.at(-1)).toBe("2026-10-01T09:00:00.000Z,Priya,Sweet,0.05");
});

test("seeded group export uses formatted amounts", () => {
const csv = exportCsv(setupDb(), "flat-4b");
expect(csv.split("\n")[0]).toBe("date,payer,description,amount");
expect(amountColumn(csv)).toEqual(["45.00", "12.00", "30.00"]);
});
});
Loading