Repository navigation
CI: the dev-database step names port 5433 - #1
Merged
Merged
Conversation
The step ran `psql -h localhost` with no -p, which means 5432 without the number ever appearing, so the port test's scan could not see it. A new test fails if any psql/createdb/dropdb/pg_dump/pg_restore line in CI connects to localhost without -p 5433. Red before, green after. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main went red when the database moved to 5433: CI's
Create dev databasestep ranpsql -h localhostwith no-p, which means 5432 without ever writing the number — so the port test's scan could not see it..github/workflows/ci.yml: that step says-p 5433.tests/test_database_port.py: a new test fails if anypsql/createdb/dropdb/pg_dump/pg_restoreline in CI connects tolocalhostwithout-p 5433. Red before the fix, green after.Expected result on this PR: the dev-database step passes; the one long-standing failure (
test_guard_blocks_real_email_in_tool_result, red since 2026-08-19) remains and is fixed separately.🤖 Generated with Claude Code