Repository navigation
The guard test gets a real-looking address again, so main goes green - #3
Merged
Merged
Conversation
test_guard_blocks_real_email_in_tool_result has failed on every CI run
since 2026-08-20. It proves the enterprise-mode guard refuses to send a
prompt carrying an apparently-real email, but the de-identification pass
moved its fixture to victim@megacorp.fake, and `.fake` is exactly what
the guard is built to let through. The test was asking the guard to
refuse a dummy address; the guard, correctly, did not.
The address is now victim@gmail.com. The de-identification gate already
allows gmail.com for this reason in writing ("consumer-domain semantics
under test"), two neighbouring tests use it, and the guard treats it as
real, so the assertion means what it says again. example.com would not
do: the guard counts it as dummy. No gate change.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_guard_blocks_real_email_in_tool_result has failed on every CI run since 2026-08-20. It proves the enterprise-mode guard refuses to send a prompt carrying an apparently-real email, but the de-identification pass moved its fixture to victim@megacorp.fake, and
.fakeis exactly what the guard is built to let through. The test was asking the guard to refuse a dummy address; the guard, correctly, did not.The address is now victim@gmail.com. The de-identification gate already allows gmail.com for this reason in writing ("consumer-domain semantics under test"), two neighbouring tests use it, and the guard treats it as real, so the assertion means what it says again. example.com would not do: the guard counts it as dummy. No gate change.