Defer auto state load for cores requiring initialization - #19487
Open
saboten731 wants to merge 1 commit into
Open
Defer auto state load for cores requiring initialization#19487saboten731 wants to merge 1 commit into
saboten731 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor
RETRO_SERIALIZATION_QUIRK_MUST_INITIALIZEwhen State Auto Load is enabled.For cores that advertise this quirk, automatic state loading is deferred until the core has had an initial execution opportunity. The existing state-loading path is then used unchanged.
Problem
Some cores are not ready to unserialize a save state immediately after content loading.
RetroArch can currently attempt State Auto Load before such a core has completed initialization. This can cause automatic loading to fail even though loading the same state manually after startup succeeds.
Solution
Track whether the active core advertises
RETRO_SERIALIZATION_QUIRK_MUST_INITIALIZE.When it does, defer the initial automatic state-load request until after the core has completed its first top-level execution cycle, then invoke the existing Auto Load path.
The deferred request is one-shot and is cleared across content/core lifecycle changes.
Cores that do not advertise
RETRO_SERIALIZATION_QUIRK_MUST_INITIALIZEcontinue to use the existing Auto Load path without the added delay.Testing
Built and tested on Android AArch64 with Mupen64Plus-Next using GLideN64/OpenGL.
With State Auto Save and State Auto Load enabled:
State saving, startup, and gameplay remained stable during testing.
Related