Add Address Library IDs for planet survey / knowledge / star-map scan - #41
Closed
pjmagee wants to merge 1 commit into
Closed
Add Address Library IDs for planet survey / knowledge / star-map scan#41pjmagee wants to merge 1 commit into
pjmagee wants to merge 1 commit into
Conversation
… paths IDs verified against Starfield 1.16.236-1.16.244 versionlibs and used in production by the Complete Planet Survey SFSE plugin. ID-only addition - no speculative class layouts (layouts remain documented at call sites until dedicated headers land). Includes: BSGalaxy knowledge manager singleton, knowledge DB lookup, PlayerKnowledge slot writers, survey notify/aggregator/scan-complete, BGSPlanet trait/progress/scan-level writers, star-map panel handlers, misc-stat table globals, scannable canonical resolve, BSTArray u32 grow, TESForm all-forms map holder. Does not fill StarMapMenu_* GetEventSource zeros: id 142196 is not a TLS-style GetEventSource and needs separate identification.
Contributor
Author
|
Consolidating fork branches: same commits now live on upstream-fixes. Replacing with a PR from pjmagee:upstream-fixes. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds verified Address Library IDs used by planet survey / PlayerKnowledge / star-map scan workflows (production-tested in Complete Planet Survey on Starfield 1.16.236–1.16.244).
ID-only PR (matches recent contributions such as book-event IDs): no speculative class layouts or offset structs. Layout notes stay in comments / call sites until dedicated headers can be proposed separately.
Namespaces added / extended
BGSPlanetSetTraitKnown52155,ProgressUpdater52157,ScanLevelWriter52173,SurveyDiscriminator938333BSGalaxy::KnowledgeManagerGetSingleton126578BSComponentDB2Lookup126806BSTArrayU32PushGrow35755MiscStatPlayerKnowledgeIncrementScanFlag124898,SetPercentByte124899,SpeciesSlotHash124901ScannableResolveCanonicalForm83006SurveyCheckNotify97853,Aggregator1016657,AggregatorBufferFree65318,ScanCompletePlanet102650StarMapRefreshPanelData93988,ScanHandler94011TESFormAllFormsMap883341Explicit non-goals
StarMapMenu_*::GetEventSourcezeros (comment id 142196 is not a TLS-style GetEventSource; needs separate RE).Test plan