Add missing libewf_extent_get_values() to support multi-extent files (and minor fix for MSVSCPP project) - #218
Open
datasynergyuk wants to merge 2 commits into
Open
Add missing libewf_extent_get_values() to support multi-extent files (and minor fix for MSVSCPP project)#218datasynergyuk wants to merge 2 commits into
datasynergyuk wants to merge 2 commits into
Conversation
…se\bzip2.lib'" in MSVSCPP build. Fix is to add 'libbz2.def' module defintion (.def) file so that the MSVSCPP project will emit required LIB file. Also modified project output filename to match bzip2/libbzip2 default of "LIBBZ2.dll". This is a partial fix for the DLL name issue. The full fix would be to rename the project "LIBBZ2", however, this may have other implications so I have not touched this.
… This will allow existing code to stop using deprecated methods get_media_data_offset()/get_media_data_size(). An extra bonus is that data_flags comes back per-extent , so per-extent sparse detection now becomes possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing libewf_extent_get_values() to support multi-extent files. This will allow existing code to stop using deprecated methods: get_media_data_offset()/get_media_data_size(). An extra bonus is that data_flags comes back per-extent, so per-extent sparse detection now becomes possible
Also fixed "LINK : fatal error LNK1181: cannot open input file '..\release\bzip2.lib'" in MSVSCPP build. Fix is to add 'libbz2.def' module defintion (.def) file so that the MSVSCPP project will emit required LIB file. Also modified project output filename to match bzip2/libbzip2 default of "LIBBZ2.dll". This is a partial fix for just the DLL name issue. The full fix would be to rename the project "LIBBZ2", however, this may have other implications so I have not touched this.