test: cover Windows short-path source bindings - #92
Merged
lidge-jun merged 1 commit intoSep 8, 2026
Merged
Conversation
lidge-jun
added a commit
to thisisjun786/codexclaw
that referenced
this pull request
Sep 8, 2026
Resolves the README test-count badge conflict from lidge-jun#92 (2,671) against this branch's 2,692, then re-measures the merged suite: 2,697 total. Also fixes two MAJOR defects found by independent review of the effort/model capability interlock. reasoningEfforts() is three-state - an array is the model's advertised ladder, null means the source did not advertise one - but the dashboard folded null into [] with '?? []', so every effort option was disabled for a model whose ladder OCX does not report, and a saved effort made those models unselectable with a misleading error. Live rosters carry that state, so this is reachable, not hypothetical. - extract effortExcluded() into gui/src/effort-support.ts, which returns true only for an actual array that omits the effort - use it at the option-disable, the save guard and the unsupported warning - add gui/test/effort-support.test.ts pinning all three states Verified: 2,697 tests pass, gui tsc --noEmit clean, inventory and gate OK.
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows 8.3 source-binding fix already landed in #84 via bb204ea. Its integration fixture expands temporary paths to long names, so the suite does not explicitly exercise a caller supplying the short alias.
Carry forward the missing regression from thisisjun786#1. It obtains an actual 8.3 alias using cmd.exe and verifies short/long binding resolution, byte-preserving repeat binding, native cwd identity, pinned source root, B/C progression, and a validated receipt executed in the linked worktree. It skips outside Windows or when the volume does not provide 8.3 aliases.
Production code is unchanged. The README test counts are updated to the measured 2,671 tests, and verification notes are included in the existing worktree-source-binding unit.
Validation (Node 24.15.0):
The regression was previously verified failing before the native-path fix and passing afterward in the original follow-up; this PR verifies it against the merged upstream implementation.