fix(gui): distinguish unmapped prompt layers from the unprintable base prompt - #5102
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe prompt probe now distinguishes unmapped layers from unexposed base prompt text. The prompt layer dialog displays a localized unmapped message. Regression and integration tests cover the behavior. ChangesUnmapped Prompt Layers
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required |
리뷰 · 우선순위 72 / 80이 PR은 프롬프트 레이어 창이 엉뚱한 이유를 보여주던 문제를 고칩니다. 프로브는 성공했는데, 아직 확인된 태그가 없는 레이어는 베이스는 라인 src/codex/prompt-text-probe.ts:78 - 라인 src/codex/prompt-text-probe.ts:106 - 라인 tests/codex-integration/codex-prompt-route.test.ts - 41번 테스트는 라우트를 호출하지 않고, 소스 파일에 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
리뷰 · 우선순위 54 / 80프롬프트 레이어 창을 열면, 프로브는 성공했는데 그 레이어의 태그를 아직 확인하지 못한 경우에도 기본 프롬프트용 설명이 나왔다. 문장은 "기본 프롬프트는 메시지 목록 밖으로 가서 여기 안 보인다. model_instructions_file로 바꿀 수 있다"이다. personality나 tools처럼 기본 프롬프트가 아닌 레이어를 연 사람에게는 틀린 안내였다. 이 PR은 그 경우를 새 이유
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
…e prompt UNMAPPED_LAYER_IDS reused the base prompt's not-exposed reason, so the dialog showed a base-prompt-specific explanation (model_instructions_file) for unrelated layers. Give them a distinct unmapped reason, render dedicated copy in the read-only dialog, and localize it across all ten locales.
608ac1f to
2298006
Compare
Motivation
Prompt layers whose rendered tag is not yet confirmed against live output were reported with
reason: "not-exposed". That reason is base-prompt-specific — its copy names the base prompt andmodel_instructions_file— so an operator opening an unrelated layer read an explanation that does not apply to it. A probe that succeeded but simply has no confirmed mapping for a layer should say exactly that.Description
probePromptText:UNMAPPED_LAYER_IDSnow reportreason: "unmapped", distinct from the base prompt''s confirmednot-exposed.PromptLayerDialogrenders the new reason with its own copy ("no confirmed mapping in the prompt output") in all locales, instead of the base-prompt explanation.Tests
bun test tests/codex-integration/codex-prompt-text-probe.test.ts— 42 pass; new case asserts unmapped layers stay distinct from the unprintable base prompt.bun test tests/codex-integration/codex-prompt-route.test.ts— 76 pass.cd gui && bun test tests/codex-set-prompt-layers.test.tsx— 17 pass; new case asserts the dialog shows the unmapped copy without base-prompt wording.bun run typecheck— clean.Screenshots
[Prompt layer dialog for an unmapped layer: the no-confirmed-mapping notice without base-prompt wording] (screenshot removed; was hosted on the contributor fork)
Summary by CodeRabbit
Bug Fixes
Localization
Tests