Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe macOS ChangesmacOS dashboard reopening
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Dock/Finder reopening uses the existing dashboard path, and closing the dashboard while the app remains active preserves its window for reuse. No concrete behavior regression is indicated. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (9 skipped: 9 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request has been marked Ready for Review. |
리뷰 · 우선순위 60 / 80맥에서 대시보드 창을 닫으면 프로그램은 메뉴 막대에 남습니다. 독이나 파인더에서 아이콘을 다시 눌러도 창이 안 나왔습니다. 앱을 두 번 켜면 나중 것이 먼저 것에 알려 주고, 그 알림만 창을 다시 띄웠습니다. 맥이 이미 켜진 앱을 다시 열 때 보내는 신호는 처리하지 않았습니다. 이 풀리퀘스트는 그 신호(
풀리퀘스트 본문 - 아직 초안입니다. 리뷰 준비 체크 네 칸이 비어 있습니다. 전체 테스트는 끝나지 않았습니다. 이번 수정과 상관없는 공급자 테스트와 API 테스트가 실패했고, 그 실패가 깨끗한 메인테이너의 판단이 필요한 지점 이 초안을 테스트 비교가 끝나기 전에 머지할지입니다. 고친 셸 코드는 다섯 줄이고, 이미 있는 창 열기 함수를 그대로 부릅니다. 맥 확인은 설치본을 갈아끼우지 않은 시험용 앱입니다. 식별자는 너의 추천 닫지 마세요. 겹치는 풀리퀘스트도 없습니다. 이 다섯 줄이 빠져 있던 다시 열기 신호를 메웁니다. 초안인 채로 머지하지 마세요. 전체 테스트와 이 댓글은 grok-bot이 작성했습니다 |
2 participants
Summary
Closing the OpenCodex window on macOS leaves the app running, but clicking its Dock icon or opening it again from Finder does not restore the dashboard. The single-instance callback handles a new process notifying the running process; it does not handle macOS reopening an already-running application.
Handle macOS
RunEvent::Reopenthrough the existingshow_dashboardentry point, including popup dismissal and deferred dashboard loading. Add a focused event-wiring regression guard and update the desktop structure contract and all eight desktop-guide locales. No new window, proxy restart, dependency, or GUI component is introduced.Verification
Head:
920c0527eef08acf4c6d07a170e0ea42d311b10c, based ondevat8b562bfc7.bun test tests/clients/desktop-exit-ownership.test.ts tests/clients/desktop-startup-surface.test.ts tests/clients/desktop-tray-availability.test.ts— 46 pass / 0 fail. This guard checks source wiring; it is not presented as a native UI test.bun run typecheck,bun run structure:check,bun run privacy:scan,git diff --check— passed.cargo fmt --manifest-path desktop/src-tauri/Cargo.toml --check,cargo clippy --locked --manifest-path desktop/src-tauri/Cargo.toml --all-targets -- -D warnings,cargo test --locked --manifest-path desktop/src-tauri/Cargo.toml— passed; 127 Rust tests passed.cd docs-site && bun install --frozen-lockfile && bun run build— passed; 505 pages and 67,206 internal links checked.openalso failed. In each case, Open Dashboard from the tray restored the same window. Notifying the single-instance callback was a passing control.TAURI_CONFIG='{"identifier":"com.opencodex.reopentest","productName":"OpenCodex Reopen Test"}' cargo build --locked --features tauri/custom-protocol --manifest-path desktop/src-tauri/Cargo.toml, then staged a separate, ad-hoc-signed test.appwith the existing 2.64.0 bundled CLI/web assets. Used isolated HOME/CODEX_HOME/OPENCODEX_HOME, a separate port, and preclaimed login markers. AppleScript drove the real close button and Dock/LaunchServices actions: window counts were 1 → 0 → 1 for both reopen paths. Accessibility inspection confirmed the proxy dashboard loaded at the isolated endpoint. Tray recovery also passed; tray Quit stopped the test shell and its proxy. The installed application was not replaced. This validates the native shell change, not a newly released full package.bun run test -- tests/clients/desktop-exit-ownership.test.ts tests/clients/desktop-startup-surface.test.ts tests/clients/desktop-tray-availability.test.ts tests/clients/desktop-start-at-login-default.test.ts tests/ci-workflows/structure-ssot.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts— 121 pass / 0 fail.bun run testwas interrupted (exit 130) after the real-home guard refused scratch cleanup inside this~/.codexworktree. Retriedbun run testin a detached/tmpworktree at this exact head. After 674 seconds, 20 failing cases had been reported; the log had not advanced for 143 seconds and both runner/test processes were at 0% CPU. The interrupted-run report namedtests/cli/ocx-launcher-runtime.test.tsas still running (292 seconds). I stopped this run with SIGINT (exit 130); later serial lanes were not executed. This is the documented resource exception, not a full-suite pass. Local readiness relies on the focused regression, Rust, typecheck, documentation, structure, privacy, and native-shell checks listed above; remaining full-suite coverage is left to hosted CI.8b562bfc7, in a separate/tmpworktree:bun run test -- tests/adapters/anthropic/anthropic-fast-opt-in.test.ts tests/server/management-provider-validation.test.ts tests/service/service-claim.test.ts tests/service/service-wsl-home-ownership.test.ts tests/codex-integration/codex-retained-root-serialization.test.ts— 150 pass / 14 fail / 1 unhandled error;bun run test -- tests/clients/remote-workspace-command-runner.test.ts tests/codex-integration/native-codex-toggle.test.ts— 23 pass / 3 fail. These reproduce 17 of the 20 observed failing cases without this patch. The other three are WSL ownership cases:bun run test -- tests/service/service-wsl-home-ownership.test.tspasses 4/4 at both base and PR head. Their full-suite-only failure remains unexplained; I am not claiming every full-suite failure is diagnosed or resolved.action_required(maintainer approval needed for the fork run). CodeRabbit completed its review of this exact head (run255ad719-e2d5-48cf-bd49-13d2f66fb94f) and reported no actionable comments; no unresolved review threads remain. Its separate docstring-coverage advisory reports 50% against its 80% threshold. This warning is retained here and is not represented as a passing check; it does not identify a behavior defect or an unresolved review finding. Hosted required CI remains a merge gate.920c0527eef08acf4c6d07a170e0ea42d311b10c: no actionable findings on either axis. These were static diff and call-path reviews, not a rerun of the native experiment. At this check, the branch is one commit behinddev(359616ef200e10ea04948237003b9df4f212698e), within the repository readiness limit.The patch touches no authentication, credential handling, release automation, workflow permissions, or dependency declarations. Reviewer findings must be resolved before readiness; hosted required checks and maintainer approval remain merge gates; skipped or approval-pending checks are not passing evidence.
Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit