Skip to content

Revert #5697 for the 2.65.0 release - #5770

Merged
lidge-jun merged 2 commits into
devfrom
codex/260925-revert-5697
Sep 24, 2026
Merged

lidge-jun merged 2 commits into
devfrom
codex/260925-revert-5697

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Reverts #5697 (24b483b510) from dev so 2.65.0 can ship on a green tree. On dev Cross-platform CI run 36030409006 (tip 45d3447767), #5697's route-policy change moved OpenCode Go aliases onto the Responses wire and broke contracts the existing suite pins: four OpenCode Go session-affinity cases in tests/providers/opencode-go-session-header.test.ts ("Claude random openai-chat to Go ..."), the Console openai-chat stream=false recovery case in tests/responses/responses-console-go-upload-retry.test.ts, and the new named-mismatch case in tests/providers/opencode-go-luna-wire.test.ts. The DeepSeek terminal-repair assertion that #5768 aligned with #5697 is restored to its original expectation.

#5697's goal (an alias at the canonical OpenCode Go endpoint gets the right wire) stays valid; it needs its route contract reconciled with those suites and will be re-landed separately.

Verification

  • bun test tests/providers/opencode-go-luna-wire.test.ts tests/providers/deepseek-inbound-wire.test.ts tests/responses/responses-console-go-upload-retry.test.ts tests/routing/router.test.ts tests/server/adapter-resolve.test.ts tests/providers/opencode-go-session-header.test.ts: 220 pass, 0 fail.
  • bun run typecheck: pass.
  • Full suite: the dev Cross-platform CI run dispatched after merge.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (Reverts an unreleased change.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (None touched.)

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 24, 2026 17:00
@lidge-jun
lidge-jun merged commit 16ea244 into dev Sep 24, 2026
5 of 7 checks passed
@lidge-jun
lidge-jun deleted the codex/260925-revert-5697 branch September 24, 2026 17:00
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T17:03:20.968343Z 47a47f3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 24, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e4eacf21-19e4-4bde-9f8e-fda916c4dfff

📥 Commits

Reviewing files that changed from the base of the PR and between 45d3447 and 47a47f3.

📒 Files selected for processing (6)
  • src/providers/registry.ts
  • src/router.ts
  • tests/providers/deepseek-inbound-wire.test.ts
  • tests/providers/opencode-go-luna-wire.test.ts
  • tests/routing/router.test.ts
  • tests/server/adapter-resolve.test.ts
 _____________________________________________
< Because, no one wants to be a human linter. >
 ---------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant