-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(codex): fence main quota publication after credential rotation #6183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9c1d7db
fix(codex): fence main quota publication after credential rotation
oocheol c185427
fix(codex): preserve quota returns while fencing stale credential writes
oocheol 406491a
fix(codex): ignore malformed usage from replaced main credentials
lidge-jun 0efca0c
test(codex): keep paced skips outside main-lock proof
lidge-jun 355cdd0
test(codex): release unchanged main response before another read
lidge-jun d39cd0e
fix(codex): keep unpublished main usage off account cards
lidge-jun 908c2d4
fix(codex): recheck stored main credential before quota publication
lidge-jun 04bb5a6
test(codex): bind direct quota fixture to live main identity
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 8169
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 42401
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 42209
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 42209
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 6486
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 11374
Do not turn unpublished main info into provider quota.
fetchMainAccountInfoSnapshotdropsinfoUnpublished. The direct provider path then convertssnapshot.info.quotainto achatgpt:whamreport. A replaced credential can therefore produce a stale provider quota report.Propagate the marker and skip unpublished info in the direct provider path.
Suggested fix
export interface MainAccountInfoSnapshot { info: MainAccountInfo; + infoUnpublished?: true; mainIdentityGeneration: number; quotaRefresh?: CodexQuotaRefreshOutcome; } export async function fetchMainAccountInfoSnapshot(forceRefresh = false, config?: OcxConfig): Promise<MainAccountInfoSnapshot> { const result = await fetchMainAccountInfoAttempt(forceRefresh, 1, undefined, false, forceRefresh, false, config); return { info: result.info, + ...(result.infoUnpublished ? { infoUnpublished: true } : {}), ...(result.quotaRefresh && result.quotaRefreshGeneration !== undefined && isMainAccountIdentityGenerationLive(result.quotaRefreshGeneration) ? { quotaRefresh: result.quotaRefresh } : {}),🤖 Prompt for AI Agents