fix(widget): isolate configurable settings defaults - #873
Open
kriss39 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 00e3225 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
None.
Why was it implemented this way?
Configurable defaults like slippage and route priority were stored in a module-level object and updated when a widget config was applied.
That makes those defaults shared across widget instances. For example, rendering one widget with a 1% slippage default could leave that value behind for another widget that did not set one.
This change derives the configurable defaults per settings store instead of mutating the shared defaults. Reset also uses the current widget config, so runtime config changes keep the expected reset behavior.
Testing
Added regression coverage for:
Validation passed with:
pnpm checkpnpm check:typesVisual showcase (Screenshots or Videos)
N/A.
Checklist before requesting a review