Skip to content

Remove stale test mypy exclusions - #2071

Open
laclance wants to merge 3 commits into
lightly-ai:masterfrom
laclance:audit-stale-mypy-exclusions
Open

laclance wants to merge 3 commits into
lightly-ai:masterfrom
laclance:audit-stale-mypy-exclusions

Conversation

@laclance

@laclance laclance commented Sep 30, 2026 •

Copy link
Copy Markdown

Part of #1635.

Removes stale mypy exclusions for test files that already pass repository-wide type checking:

  • tests/cli/test_cli_get_lighty_config.py
  • tests/utils/benchmarking/test_topk.py
  • tests/utils/benchmarking/test_knn.py

Validation:

  • make type-check
  • make format-check

I also checked tests/utils/benchmarking/test_linear_classifier.py; it passes when checked in isolation but still produces type errors during the full repository-wide mypy run, so it remains excluded.

Remove mypy exclusions for tests/cli/test_cli_get_lighty_config.py, tests/utils/benchmarking/test_topk.py, and tests/utils/benchmarking/test_knn.py. Keep the exclusions for test_knn_classifier.py and test_linear_classifier.py.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1eb149a0-cfc4-4ec3-a048-3c329e21edac
Commits

Reviewing files that changed from the base of the PR and between 1acc4c6 and db65b72.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 70a577bc-1690-46a1-94e7-906c35af5b76
📥 Commits

Reviewing files that changed from the base of the PR and between 7f83d55 and 1acc4c6.

📒 Files selected for processing: 1
  • pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The mypy exclusion list removes three test files and adds tests/utils/benchmarking/test_knn_classifier.py.

Changes: Mypy exclusions

Layer / File(s) Summary
Update mypy exclusions
pyproject.toml
The exclusion list removes tests/cli/test_cli_get_lighty_config.py, tests/utils/benchmarking/test_topk.py, and tests/utils/benchmarking/test_knn.py. It adds tests/utils/benchmarking/test_knn_classifier.py.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: sauravmaheshkar

Merge Risk: Minimal · up to 1acc4

The change updates which tests repository-wide type checking covers. No concrete merge-blocking issue is established, so the PR presents minimal known risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing stale mypy exclusions from test files.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@laclance laclance mentioned this pull request Sep 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant