Repository navigation
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
| Layer / File(s) | Summary |
|---|---|
Update mypy exclusions pyproject.toml |
The exclusion list removes tests/cli/test_cli_get_lighty_config.py, tests/utils/benchmarking/test_topk.py, and tests/utils/benchmarking/test_knn.py. It adds tests/utils/benchmarking/test_knn_classifier.py. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Suggested reviewers: sauravmaheshkar
Merge Risk: 
Minimal · up to 1acc4
-
The change updates which tests repository-wide type checking covers. No concrete merge-blocking issue is established, so the PR presents minimal known risk.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Part of #1635.
Removes stale mypy exclusions for test files that already pass repository-wide type checking:
tests/cli/test_cli_get_lighty_config.pytests/utils/benchmarking/test_topk.pytests/utils/benchmarking/test_knn.pyValidation:
make type-checkmake format-checkI also checked
tests/utils/benchmarking/test_linear_classifier.py; it passes when checked in isolation but still produces type errors during the full repository-wide mypy run, so it remains excluded.Remove mypy exclusions for
tests/cli/test_cli_get_lighty_config.py,tests/utils/benchmarking/test_topk.py, andtests/utils/benchmarking/test_knn.py. Keep the exclusions fortest_knn_classifier.pyandtest_linear_classifier.py.