Add features to graph node announcement #237
Open
enigbe wants to merge 1 commit into
Open
Conversation
Include the feature map from LDK's NodeAnnouncementInfo in GraphNodeAnnouncement. Features are part of the BOLT 7 node_announcement payload, so exposing them makes the graph node announcement proto match the underlying gossip data more completely. Reuse the existing bit-keyed Feature representation and conversion helper, and cover the new field in the graph-get-node e2e test. This also supports callers such as sim-ln that need to inspect other nodes' advertised capabilities. For context: bitcoin-dev-project/sim-ln#307 https://github.com/bitcoin-dev-project/sim-ln/pull/307/changes#r3481510079
|
I've assigned @benthecarman as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Include the feature map from LDK's
NodeAnnouncementInfoinGraphNodeAnnouncement. Features are part of the BOLT 7node_announcementmessage, so exposing them makes the graph node announcement proto match the underlying gossip data more completely.Reuse the existing bit-keyed
Featurerepresentation and conversion helper, and cover the new field in thegraph-get-nodee2e test. This also supports callers such assim-lnthat need to inspect other nodes' advertised capabilities.For context:
bitcoin-dev-project/sim-ln#307 https://github.com/bitcoin-dev-project/sim-ln/pull/307/changes#r3481510079