Skip to content

feat: add EU legal forms to business entity type - #782

Merged
jklein24 merged 1 commit into
mainfrom
07-31-entity-type-eu-legal-forms
Jul 31, 2026
Merged

feat: add EU legal forms to business entity type#782
jklein24 merged 1 commit into
mainfrom
07-31-entity-type-eu-legal-forms

Conversation

@jklein24

Copy link
Copy Markdown
Contributor

Summary

Adds four legal entity types to EntityType so businesses incorporated outside the US can be described faithfully:

  • PUBLICLY_LISTED_COMPANY
  • TRUST
  • PRIVATE_FOUNDATION
  • CHARITY

The existing members are US-shaped (LLC, S_CORPORATION, SOLE_PROPRIETORSHIP), so a publicly listed company, trust, foundation or charity could previously only be recorded as OTHER. Downstream verification providers distinguish these forms, and OTHER is not always accepted in their place — so the imprecision could block business verification rather than merely lose detail.

OTHER is retained for genuinely unlisted forms.

Compatibility

Additive only — no existing value changes meaning, and no field becomes required.

oasdiff breaking reports 0 errors, 40 warnings (all response-property-enum-value-added), so info.version is unchanged per the repo's convention of bumping only for breaking changes.

Clients that exhaustively switch on entityType should handle unknown values, as with any enum in this spec.

Test plan

  • make build — spec rebundled (openapi.yaml + mintlify/openapi.yaml)
  • make lint-openapi — passes, 0 errors
  • oasdiff breaking <base> <head> --fail-on ERR — exit 0

Requested by @jklein24

Original PR: #781

@ls-bolt ls-bolt Bot added the bolt label Jul 31, 2026
@jklein24
jklein24 marked this pull request as ready for review July 31, 2026 17:12

Copy link
Copy Markdown

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jklein24
jklein24 enabled auto-merge (squash) July 31, 2026 17:12
@jklein24
jklein24 requested a review from shreyav July 31, 2026 17:12
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

feat: add EU legal forms to business entity type

go

feat(api): add entity type enum values to customer business info

kotlin

feat: add EU legal forms to business entity type

openapi

feat: add EU legal forms to business entity type

php

feat: add EU legal forms to business entity type

python

feat: add EU legal forms to business entity type

ruby

feat: add EU legal forms to business entity type

typescript

feat: add EU legal forms to business entity type
⚠️ grid-openapi studio · code

Your SDK build had at least one "warning" diagnostic.
generate ⚠️

grid-ruby studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ✅lint ✅test ✅

⚠️ grid-go studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅build ✅lint ❗test ❗

go get github.com/stainless-sdks/grid-go@ff0b9b3f7bad35b9b035450783fecfbedf201729
⚠️ grid-kotlin studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ⚠️build ✅lint ✅test ❗

⚠️ grid-python studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅build ✅lint ❗test ❗

pip install https://pkg.stainless.com/s/grid-python/587bb7e797ec97c9ee3236becd00458b9a580ed8/grid-0.0.1-py3-none-any.whl
grid-php studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅lint ✅test ✅

grid-typescript studio · conflict

Your SDK build had at least one note diagnostic.

⚠️ grid-cli studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ⚠️build ⏭️lint ⏭️test ❗


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-07-31 17:19:58 UTC

@jklein24
jklein24 merged commit 79f2666 into main Jul 31, 2026
17 of 18 checks passed
@jklein24
jklein24 deleted the 07-31-entity-type-eu-legal-forms branch July 31, 2026 17:14
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

⚔️☠️ EU LEGAL FORMS ENTER THE ENUM FORGE — LET THE VERIFICATION RIFFS BEGIN! ☠️⚔️
/
/ \ _ _ ___ _____ _ _
/ /\ \ | || | / _ _ || | | |
/
/ _\ | __ || () || | | || |
|||| _/ |_| _/

This PR additively expands the business entity-type vocabulary for non-US legal forms.

  • Adds PUBLICLY_LISTED_COMPANY, TRUST, PRIVATE_FOUNDATION, and CHARITY to the source EntityType schema.
  • Rebuilds both committed OpenAPI bundles with the same four values.
  • Retains all existing enum members, including OTHER, without changing field requirements or existing meanings.

Confidence Score: 5/5

The PR appears safe to merge because the additive enum extension is consistent across the canonical schema and both generated bundles.

The new legal-form values follow the repository’s enum naming and additive-compatibility conventions, while all generated artifacts remain synchronized with the source schema.

Important Files Changed

Filename Overview
openapi/components/schemas/customers/EntityType.yaml Adds four valid upper-snake-case legal entity values to the canonical customer schema without altering existing values.
openapi.yaml Updates the committed root bundle consistently with the canonical EntityType schema.
mintlify/openapi.yaml Updates the Mintlify bundle consistently with the canonical schema and root bundle.

Reviews (1): Last reviewed commit: "feat: add EU legal forms to business ent..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants