Repository navigation
Specify cli root_dir as Path to avoid str / str operation - #21
Merged
Merged
Conversation
Add support for expanding user directory in lbench root path
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
========================================
- Coverage 3.48% 3.47% -0.01%
========================================
Files 26 26
Lines 1062 1064 +2
========================================
Hits 37 37
- Misses 1025 1027 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing --lbench-root crashes at startup with
TypeError: unsupported operand type(s) for /: 'str' and 'str'Currently:
We have 2 ways to set the root dir:
In
src/lbench/pytest/plugin.py, we call:Proposed change:
Adding
type=Pathto the "--lbench-root" optionThis lets us specify the root_dir via the cli, and still construct the run_dir path construction via the
/operator.