Implement reduce_min()/reduce_max() and their precise variants - #358
Merged
Conversation
LaurenzV
approved these changes
Aug 30, 2026
LaurenzV
left a comment
LaurenzV
left a comment
Collaborator
There was a problem hiding this comment.
Why is everything so much easier on NEON compared to AVX2! 😄
…ly used SSE2 just to suppress some pointless lints about no-op stuff in generated code
Shnatsel
force-pushed
the
reduce-min-max
branch
from
August 30, 2026 09:14
a6fc0d7 to
578ce36
Compare
Shnatsel
enabled auto-merge
August 30, 2026 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simpler part of #340
Implementation decisions largely mirror #357 but we don't have to worry about error accumulation in floats. API design follows the existing lane-wise min/max.
cc @Mnwa who requested this feature