sparse_strips: Fix issues on big-endian targets - #1845
Open
LaurenzV wants to merge 3 commits into
Open
Conversation
LaurenzV
marked this pull request as ready for review
August 25, 2026 11:09
grebmeg
reviewed
Aug 28, 2026
Comment on lines
+349
to
+381
| test-stable-big-endian: | ||
| name: cargo test (big-endian, powerpc64) | ||
| needs: prime-lfs-cache | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Restore lfs cache | ||
| id: lfs-cache | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: .git/lfs | ||
| key: vello-lfs-${{ needs.prime-lfs-cache.outputs.lfs-hash }} | ||
| enableCrossOsArchive: true | ||
|
|
||
| - name: Checkout LFS files | ||
| run: git lfs checkout '${{ join(fromJson(env.LFS_FILES), ''' ''') }}' | ||
| continue-on-error: true | ||
|
|
||
| - name: install stable toolchain | ||
| uses: dtolnay/rust-toolchain@master | ||
| with: | ||
| toolchain: ${{ env.RUST_STABLE_VER }} | ||
|
|
||
| - name: install cross | ||
| uses: taiki-e/install-action@v2 | ||
| with: | ||
| tool: cross | ||
|
|
||
| - name: cargo test | ||
| run: cross test -p vello_sparse_tests --test tests --locked --release --target powerpc64-unknown-linux-gnu _scalar | ||
| env: | ||
| CARGO_PROFILE_RELEASE_DEBUG_ASSERTIONS: "true" |
Collaborator
There was a problem hiding this comment.
Given how rare big-endian targets are and our already long, capacity-constrained CI, does this justify running the full scalar suite on every PR? Also, I'm cursiour, how did you discover this issue originally?
Collaborator
Author
There was a problem hiding this comment.
Sure, as mentioned in the Zulip thread, happy to remove the CI part. To be honest I don't really remember anymore. 😅 I think it was when reviewing a fearless_simd PR where we discovered an issue with endianness and that's how I thought of taking a look at whether vello has similar issues.
This reverts commit 8d672a3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit adds a CI step that runs (only scalar) tests from
vello_sparse_testson a big-endian target. As you can see, it's completetly broken.Second commit fixes this by making the
u8_to_f32andf32_to_u8methods aware of endianness