TPT-4475: Add integration tests for Configurable VPC top-level IPv4 Prefixes#905
Open
mawilk90 wants to merge 3 commits into
Conversation
mawilk90
requested review from
Copilot,
ezilber-akamai,
psnoch-akamai and
zliang-akamai
and removed request for
a team and
zliang-akamai
mawilk90
added
testing
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new integration coverage for configurable VPC top-level IPv4 ranges/prefix behavior in the Linode CLI test suite, validating both successful VPC creation with custom IPv4 ranges and failure behavior for forbidden ranges.
Changes:
- Added an integration test to validate
default-ranges-all-listreturns IPv4 default/forbidden ranges as lists. - Added parametrized integration tests to create VPCs with 1–2 custom IPv4 ranges and verify they are reflected in
vpcs view. - Added a negative integration test to ensure creating a VPC with a forbidden IPv4 range fails with a 400 and expected error text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/integration/vpc/test_vpc.py | Adds new integration tests for default/forbidden IPv4 ranges and VPC creation with configurable IPv4 ranges. |
| tests/integration/vpc/conftest.py | Adds a fixture to create and clean up VPCs using custom IPv4 CLI arguments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Intergration tests for configurable VPC IPv4
NOTE:
PR with openapi.json is already merged, however openapi.json file is not updated yet in linode-api-openapi repo so CLI can be build locally only using the latest openapi.json taken from the PR mentioned above
✔️ How to Test
make test-int TEST_SUITE=vpc TEST_ARGS="-k test_get_vpc_default_ranges"make test-int TEST_SUITE=vpc TEST_ARGS="-k test_vpc_with_ipv4"make test-int TEST_SUITE=vpc TEST_ARGS="-k test_vpc_update_with_ipv4"make test-int TEST_SUITE=vpc TEST_ARGS="-k test_vpc_with_forbidden_ipv4_fail"