contents: Don't ignore ignored entries#262
Open
quic-bjorande wants to merge 1 commit into
Open
Conversation
While it would make sense to ignore entries explicitly marked to be ignored, some builds apparently depend on these ignored files. Drop the check for ignored to make it possible to flash those builds. Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Contributor
Author
|
It's unclear if this patch is correct... |
lumag
reviewed
Jun 27, 2026
| return -1; | ||
| } | ||
|
|
||
| if (contents_entry_is_ignored(node)) |
Contributor
There was a problem hiding this comment.
I'd guess it needs some explanation, why we should not ignore the files flagged to be ignored.
Collaborator
There was a problem hiding this comment.
I've not found any description of what it is that the "ignored" attribute implies that we should ignore, and so far it's only one target that I've run into where we need to ignore the ignore-flag.
I don't think we should merge this until we get clarity in the purpose of this attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it would make sense to ignore entries explicitly marked to be ignored, some builds apparently depend on these ignored files.
Drop the check for ignored to make it possible to flash those builds.