Skip to content

[PW_SID:1136511] pinctrl: spacemit: validate pins in pinconf callbacks - #2384

Closed
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw1136511
Closed

[PW_SID:1136511] pinctrl: spacemit: validate pins in pinconf callbacks#2384
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw1136511

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown

PR for series 1136511 applied to workflow__riscv__fixes

Name: pinctrl: spacemit: validate pins in pinconf callbacks
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1136511
Version: 1

covanam and others added 3 commits July 20, 2026 19:18
@covanam Paul Walmsley
riscv: time: Add missing __iomem in get_cycles() and get_cycles_hi()
1d6f0a2 
__iomem is missing while calling readl_relaxed() in get_cycles() and
get_cycles_hi() and sparse complains.

Add __iomem to silence the sparse warnings.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202607160619.14G8GHp5-lkp@intel.com/
Signed-off-by: Nam Cao <namcao@linutronix.de>
Link: https://patch.msgid.link/20260716053319.2178937-1-namcao@linutronix.de
Signed-off-by: Paul Walmsley <pjw@kernel.org>
Linux RISC-V bot
Adding CI files
36eafdd
@TroyMitchell911 Linux RISC-V bot
pinctrl: spacemit: validate pins in pinconf callbacks
318ca79 
Pin 0 is a valid pin ID, but spacemit_pinconf_get() rejects it by
testing the numeric ID rather than the result of the descriptor lookup.
It also fails to reject nonzero IDs absent from the SoC pin table before
computing their register addresses. Check the descriptor and use its pin
ID for the register lookup.

spacemit_pinconf_group_set() validates only the first group member when
generating the configuration. If a later member is invalid,
spacemit_pin_set_config() returns -EINVAL, but the callback ignores it
and reports success after partially updating the group.

Validate every group member before writing any registers so malformed
groups fail without being partially applied.

Fixes: a83c29e ("pinctrl: spacemit: add support for SpacemiT K1 SoC")
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Reviewed-by: Yixun Lan <dlan@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 117.03 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1390.60 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1701.97 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.71 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.60 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.48 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
kdoc
Desc: Detects for kdoc errors
Duration: 0.70 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
module-param
Desc: Detect module_param changes
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 29, 2026

Copy link
Copy Markdown
Author

Patch 1: "pinctrl: spacemit: validate pins in pinconf callbacks"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow__riscv__fixes branch 5 times, most recently from 971bf8c to caa07c5 Compare August 4, 2026 02:48
@linux-riscv-bot
linux-riscv-bot deleted the pw1136511 branch August 6, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linux-riscv-bot @covanam @TroyMitchell911