[PW_SID:1146918] [V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids - #2480
[PW_SID:1146918] [V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids#2480linux-riscv-bot wants to merge 4 commits into
Conversation
…_RWX When CONFIG_STRICT_MODULE_RWX is not set, execmem cannot create temporary writable mappings for read-only executable pages. In this case, the execmem ranges must already have writable permissions. Currently EXECMEM_KPROBES unconditionally uses PAGE_KERNEL_READ_EXEC, which causes kprobe instruction slot writes to trigger page faults on systems where CONFIG_STRICT_MODULE_RWX is not enabled. Fix this by using PAGE_KERNEL_EXEC when CONFIG_STRICT_MODULE_RWX is not available. Signed-off-by: Xiaofeng Yuan <xiaofengmian@163.com> Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Nam Cao <namcao@linutronix.de> Link: https://patch.msgid.link/20260814082742.148403-2-xiaofengmian@163.com Signed-off-by: Paul Walmsley <pjw@kernel.org>
patch_map() always creates a temporary writable mapping via fixmap for kernel text addresses, even when CONFIG_STRICT_KERNEL_RWX is disabled and the kernel text is already mapped with _PAGE_WRITE. This is unnecessary overhead at best, and on minimal configurations it can cause page faults. Skip the fixmap path for kernel text when CONFIG_STRICT_KERNEL_RWX is not enabled, since the text pages are already writable in that case. The module text path is already gated on CONFIG_STRICT_MODULE_RWX and is kept unchanged. Reported-by: Klara Modin <klara@kasm.eu> Closes: https://lore.kernel.org/all/ant_8TaBbov_GS4i@soda.int.kasm.eu/ Reported-by: Lad Prabhakar <prabhakar.csengg@gmail.com> Closes: https://lore.kernel.org/all/CA+V-a8tQK8rih9SGGTyqrEBGpNkx4H0eX2YccCRrgkVAPr+EBg@mail.gmail.com/ Tested-by: Klara Modin <klarasmodin@gmail.com> Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Link: https://patch.msgid.link/20260814082742.148403-3-xiaofengmian@163.com Signed-off-by: Paul Walmsley <pjw@kernel.org>
The initial K3 device tree used generic/placeholder values for the
IMSIC guest configuration:
riscv,num-guest-ids = <511>;
According to the SpacemiT K3 User Manual this values is incorrect
for the X100 cores:
- Advanced Interrupt Architecture (AIA):
- M-mode MSI: 512
- S-mode MSI: 512
- VS-mode MSI: 64
Therefore, S-mode IMSIC (simsic) needs num-guest-ids = 63.
Fixes: 56f37e3 ("riscv: dts: spacemit: add initial support for K3 SoC")
Cc: stable@vger.kernel.org
Cc: Guodong Xu <docular.xu@gmail.com>
Cc: Yixun Lan <dlan@kernel.org>
Signed-off-by: GUO Ren (XuanTie) <guoren@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
|
Patch 1: "[V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids" |
bb1a926 to
6f6f7c0
Compare
3 participants
PR for series 1146918 applied to workflow__riscv__fixes
Name: [V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1146918
Version: 2