[PW_SID:1148143] irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback - #2489
[PW_SID:1148143] irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback#2489linux-riscv-bot wants to merge 4 commits into
Conversation
…_RWX When CONFIG_STRICT_MODULE_RWX is not set, execmem cannot create temporary writable mappings for read-only executable pages. In this case, the execmem ranges must already have writable permissions. Currently EXECMEM_KPROBES unconditionally uses PAGE_KERNEL_READ_EXEC, which causes kprobe instruction slot writes to trigger page faults on systems where CONFIG_STRICT_MODULE_RWX is not enabled. Fix this by using PAGE_KERNEL_EXEC when CONFIG_STRICT_MODULE_RWX is not available. Signed-off-by: Xiaofeng Yuan <xiaofengmian@163.com> Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Nam Cao <namcao@linutronix.de> Link: https://patch.msgid.link/20260814082742.148403-2-xiaofengmian@163.com Signed-off-by: Paul Walmsley <pjw@kernel.org>
patch_map() always creates a temporary writable mapping via fixmap for kernel text addresses, even when CONFIG_STRICT_KERNEL_RWX is disabled and the kernel text is already mapped with _PAGE_WRITE. This is unnecessary overhead at best, and on minimal configurations it can cause page faults. Skip the fixmap path for kernel text when CONFIG_STRICT_KERNEL_RWX is not enabled, since the text pages are already writable in that case. The module text path is already gated on CONFIG_STRICT_MODULE_RWX and is kept unchanged. Reported-by: Klara Modin <klara@kasm.eu> Closes: https://lore.kernel.org/all/ant_8TaBbov_GS4i@soda.int.kasm.eu/ Reported-by: Lad Prabhakar <prabhakar.csengg@gmail.com> Closes: https://lore.kernel.org/all/CA+V-a8tQK8rih9SGGTyqrEBGpNkx4H0eX2YccCRrgkVAPr+EBg@mail.gmail.com/ Tested-by: Klara Modin <klarasmodin@gmail.com> Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Link: https://patch.msgid.link/20260814082742.148403-3-xiaofengmian@163.com Signed-off-by: Paul Walmsley <pjw@kernel.org>
…lback
The IRQ core calls the irq_domain .activate callback from __setup_irq()
with desc->lock held and interrupts disabled. Both
aspeed_intc1_irq_domain_activate() and the aspeed_intc0_resolve_route()
it invokes test a compatible string with fwnode_device_is_compatible(),
which wraps fwnode_property_match_string() and allocates with GFP_KERNEL.
Besides sleeping in atomic context, that makes the irq_desc lock depend
on fs_reclaim, which lockdep reports as an inversion because
irq_desc_lock_class is also taken in hardirq context:
WARNING: possible irq lock inversion dependency detected
swapper/0/0 just changed the state of lock:
(&irq_desc_lock_class){-...}-{2:2}, at: handle_level_irq+0x28/0x168
but this lock took another, HARDIRQ-unsafe lock in the past:
(fs_reclaim){+.+.}-{0:0}
...
fs_reclaim_acquire
__kmalloc_noprof
fwnode_property_match_string
aspeed_intc0_resolve_route
aspeed_intc1_irq_domain_activate
Both call sites are only ever handed OF nodes, so use
of_device_is_compatible() instead: it walks the property in place and
does not allocate.
Fixes: 07825e4 ("irqchip/ast2700-intc: Add AST2700-A2 support")
Reported-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
|
Patch 1: "irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback" |
bb1a926 to
6f6f7c0
Compare
3 participants
PR for series 1148143 applied to workflow__riscv__fixes
Name: irqchip/ast2700-intc: Avoid allocating in the irq_domain activate callback
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1148143
Version: 1