Skip to content

[PW_SID:1148177] [RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range - #2490

Closed
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw1148177
Closed

[PW_SID:1148177] [RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range#2490
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw1148177

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown

PR for series 1148177 applied to workflow__riscv__fixes

Name: [RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1148177
Version: 1

ThreeBottleCap and others added 4 commits August 14, 2026 14:12
@ThreeBottleCap Paul Walmsley
riscv: mm: make EXECMEM_KPROBES writable without CONFIG_STRICT_MODULE…
784f45c 
…_RWX

When CONFIG_STRICT_MODULE_RWX is not set, execmem cannot create
temporary writable mappings for read-only executable pages. In this
case, the execmem ranges must already have writable permissions.

Currently EXECMEM_KPROBES unconditionally uses PAGE_KERNEL_READ_EXEC,
which causes kprobe instruction slot writes to trigger page faults
on systems where CONFIG_STRICT_MODULE_RWX is not enabled.

Fix this by using PAGE_KERNEL_EXEC when CONFIG_STRICT_MODULE_RWX
is not available.

Signed-off-by: Xiaofeng Yuan <xiaofengmian@163.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Link: https://patch.msgid.link/20260814082742.148403-2-xiaofengmian@163.com
Signed-off-by: Paul Walmsley <pjw@kernel.org>
@ThreeBottleCap Paul Walmsley
riscv: patch: skip fixmap mapping when kernel text is already writable
8d9d4fd 
patch_map() always creates a temporary writable mapping via fixmap for
kernel text addresses, even when CONFIG_STRICT_KERNEL_RWX is disabled
and the kernel text is already mapped with _PAGE_WRITE.

This is unnecessary overhead at best, and on minimal configurations
it can cause page faults.

Skip the fixmap path for kernel text when CONFIG_STRICT_KERNEL_RWX
is not enabled, since the text pages are already writable in that case.
The module text path is already gated on CONFIG_STRICT_MODULE_RWX and
is kept unchanged.

Reported-by: Klara Modin <klara@kasm.eu>
Closes: https://lore.kernel.org/all/ant_8TaBbov_GS4i@soda.int.kasm.eu/
Reported-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Closes: https://lore.kernel.org/all/CA+V-a8tQK8rih9SGGTyqrEBGpNkx4H0eX2YccCRrgkVAPr+EBg@mail.gmail.com/
Tested-by: Klara Modin <klarasmodin@gmail.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://patch.msgid.link/20260814082742.148403-3-xiaofengmian@163.com
Signed-off-by: Paul Walmsley <pjw@kernel.org>
Linux RISC-V bot
Adding CI files
492cc66
@qiyeliu Linux RISC-V bot
mm/page_table_check: add explicit pmd_none check in pte_clear_range
fbd1eda 
In __page_table_check_pte_clear_range(), the condition to determine
whether to iterate over PTEs only checked pmd_bad() and pmd_leaf().
This relies on the implicit assumption that pmd_none() is always a
subset of pmd_bad() on all architectures supporting PAGE_TABLE_CHECK.

While this assumption currently holds for x86_64, arm64, s390, riscv,
and powerpc, it is an architecture-dependent behavior that may not
hold for future architectures. Add an explicit pmd_none() check to
make the intent clear and avoid calling pte_offset_map() on an empty
PMD, which could lead to undefined behavior.

Signed-off-by: Ye Liu <liuye@kylinos.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 142.68 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1422.74 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1730.05 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.48 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.16 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.74 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 87.74 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Patch 1: "[RESEND] mm/page_table_check: add explicit pmd_none check in pte_clear_range"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow__riscv__fixes branch 2 times, most recently from bb1a926 to 6f6f7c0 Compare August 21, 2026 03:35
@linux-riscv-bot
linux-riscv-bot deleted the pw1148177 branch August 28, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linux-riscv-bot @ThreeBottleCap @qiyeliu